riotbuild: Install python3-venv #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspar030
approved these changes
Feb 26, 2024
Member
Author
|
Turns out this was done at the wrong place, should have been RIOT-OS/murdock-scripts#53. I'm suggesting to leave this in anyway -- it's also in #239, and the more we move away from shell script, the more often we'll find the need to do quick venv operations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have a user for it yet in RIOT, but I'm working on a tool in RIOT-OS/RIOT#20395 that'd make good use of it. (Essentially it's installing requirements.txt of local tools into venvs on demand, removing the need to have all modules used anywhere as dependencies of RIOT-as-a-whole. It'd still be preferable if the modules were avaialble in riotdocker, but the flexibility makes PRs easier without going through riotdocker first for every single thing.)
Note that you can do
python3 -m venvin the container already, but without the python3-venv Debian package, it can't set up a pip inside venv, and usually that's the very reason why one would use a venv in the first place (and the tool mentioned above relies on it).