Skip to content

Cherry pick fix for triton ops deprecation#57

Merged
pnunna93 merged 3 commits intorocm_enabled_multi_backendfrom
fix_triton_ops
Feb 21, 2025
Merged

Cherry pick fix for triton ops deprecation#57
pnunna93 merged 3 commits intorocm_enabled_multi_backendfrom
fix_triton_ops

Conversation

@pnunna93
Copy link

This PR cherry picks a fix from upstream to resolve error with triton ops deprecation.

bertmaher and others added 2 commits February 20, 2025 19:44
…1413)

* Remove triton.ops, copy necessary bits here

Summary: Triton upstream removed `triton.ops` and moved it to a
semi-unmaintained `kernels` repo.  Since all that's needed here is the perf
model, just add those bits here.

* Add source reference/license comment
@pnunna93 pnunna93 requested review from Lzy17 and lcskrishna February 20, 2025 21:53
Copy link

@lcskrishna lcskrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this is a new kernel that we need to focus next as the test is disabled which was enabled before?

@pnunna93
Copy link
Author

They were part of triton.ops, ops is deprecated in triton, so they are added directly in bitsandbytes now instead of importing.

@pnunna93 pnunna93 merged commit 35266ea into rocm_enabled_multi_backend Feb 21, 2025
10 of 26 checks passed
@pnunna93 pnunna93 deleted the fix_triton_ops branch February 21, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments