Skip to content

1.Fixed error in getting mcu model number; #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kurisaW merged 1 commit into from
Jun 16, 2025
Merged

1.Fixed error in getting mcu model number; #3

kurisaW merged 1 commit into from
Jun 16, 2025

Conversation

@Maihuanyi
Copy link

@Maihuanyi Maihuanyi commented Jun 12, 2025

IMPORTANT INFORMATION

Contributor License Agreement (CLA)

  • The Pull Request feature will be considered by STMicroelectronics after the signature of a Contributor License Agreement (CLA) by the submitter.
  • If you did not sign such agreement, please follow the steps mentioned in the CONTRIBUTING.md file.

@kurisaW
Copy link
Member

kurisaW commented Jun 13, 2025

请问这么修改的原因是什么？看起来只是加了个CPPDEFINES？

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 13, 2025 via email

@kurisaW
Copy link
Member

kurisaW commented Jun 16, 2025

这个问题已经有PR修复过，更建议从bsp级别修复，可参考此PR：

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 16, 2025 •
edited
Loading

就是在这个PR下测试的呀？env.Append(CPPDEFINES = ['STM32F103xB'])加到环境变量里面，在使用env.get('CPPDEFINES', [])获取回来的是一个元组，比如获取回来的是带逗号的，在使用list匹配tuple获取不了型号回来，你可以测试一下linux的环境，启动文件是没有编译的

@kurisaW
Copy link
Member

kurisaW commented Jun 16, 2025 •
edited
Loading

我这边使用stm32f407-rt-spark测试是正常的，直接使用主线最新源码编译测试，请问你用的是哪个bsp？我这边测试看看

测试正常截图：
image

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 16, 2025

stm32f103-100ask-mini

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 16, 2025

在这个节点分出来使用的
Uploading image.png…

@kurisaW
Copy link
Member

kurisaW commented Jun 16, 2025

我这边测试正常，同时附上我的scons版本：

image

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 16, 2025

image
s重新克隆rtthread了，使用stm32f407-st-discovery编译的log

@kurisaW
Copy link
Member

kurisaW commented Jun 16, 2025 •
edited
Loading

正常现象，你估计本地git仓库不是最新的，这个PR可以关闭了，有问题后续欢迎向官方反馈

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 16, 2025

我重新拉最新的主仓库的，我在里面添加打印如下图
image
image
编译的时候芯片的型号的名称后面是带逗号的，所以匹配不了，启动文件不参与编译的

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 16, 2025

如果可以在主分支修复，我早就PR修复了

@kurisaW
Copy link
Member

kurisaW commented Jun 16, 2025

有试过用主线最新版本重新构建并下载测试吗，什么其他操作都不用执行，拉下来仓库，直接pkgs --update，然后编译下载，在我这边是能看到启动汇编文件加入到构建中的，并且经过烧录能正常运行：

image

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 16, 2025

拉取最新版本的仓库的，拉下来直接pkgs --update，然后编译的，我同事也是这个问题；我两个ubuntu都是这样的情况

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 16, 2025

ubuntu22

@kurisaW
Copy link
Member

kurisaW commented Jun 16, 2025

scons版本看一下？

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 16, 2025

image

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 16, 2025

又重下了一个`mhy@chaselsv:/test$ git clone https://gitee.com/rtthread/rt-thread.git
Cloning into 'rt-thread'...
remote: Enumerating objects: 289767, done.
remote: Counting objects: 100% (2189/2189), done.
remote: Compressing objects: 100% (1312/1312), done.
remote: Total 289767 (delta 1052), reused 1484 (delta 839), pack-reused 287578 (from 1)
Receiving objects: 100% (289767/289767), 855.22 MiB | 8.02 MiB/s, done.
Resolving deltas: 100% (211711/211711), done.
Updating files: 100% (38427/38427), done.
mhy@chaselsv:/test$ cd rt-thread/bsp/stm32/stm32f407-st-discovery/
mhy@chaselsv:/test/rt-thread/bsp/stm32/stm32f407-st-discovery$ vi rtconfig.py
mhy@chaselsv:/test/rt-thread/bsp/stm32/stm32f407-st-discovery$ pkgs --update
[Use Github server - auto decision based on IP location]
Cloning into '/home/mhy/test/rt-thread/bsp/stm32/stm32f407-st-discovery/packages/CMSIS-Core-latest'...
remote: Enumerating objects: 44, done.
remote: Counting objects: 100% (44/44), done.
remote: Compressing objects: 100% (21/21), done.
remote: Total 44 (delta 23), reused 41 (delta 22), pack-reused 0 (from 0)
Receiving objects: 100% (44/44), 131.70 KiB | 698.00 KiB/s, done.
Resolving deltas: 100% (23/23), done.
remote: Total 0 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0)
From https://github.com/RT-Thread-packages/CMSIS-Core

  • branch master -> FETCH_HEAD
    ==============================> CMSIS_CORE latest is downloaded successfully.

Cloning into '/home/mhy/test/rt-thread/bsp/stm32/stm32f407-st-discovery/packages/stm32f4_hal_driver-latest'...
remote: Enumerating objects: 1326, done.
remote: Counting objects: 100% (478/478), done.
remote: Compressing objects: 100% (141/141), done.
remote: Total 1326 (delta 406), reused 339 (delta 337), pack-reused 848 (from 1)
Receiving objects: 100% (1326/1326), 2.62 MiB | 995.00 KiB/s, done.
Resolving deltas: 100% (1024/1024), done.
remote: Total 0 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0)
From https://github.com/RT-Thread-packages/stm32f4_hal_driver

  • branch master -> FETCH_HEAD
    ==============================> STM32F4_HAL_DRIVER latest is downloaded successfully.

Cloning into '/home/mhy/test/rt-thread/bsp/stm32/stm32f407-st-discovery/packages/stm32f4_cmsis_driver-latest'...
remote: Enumerating objects: 599, done.
remote: Counting objects: 100% (97/97), done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 599 (delta 91), reused 86 (delta 84), pack-reused 502 (from 1)
Receiving objects: 100% (599/599), 1.93 MiB | 704.00 KiB/s, done.
Resolving deltas: 100% (499/499), done.
remote: Total 0 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0)
From https://github.com/RT-Thread-packages/stm32f4_cmsis_driver

  • branch master -> FETCH_HEAD
    ==============================> STM32F4_CMSIS_DRIVER latest is downloaded successfully.

/home/mhy/test/rt-thread/bsp/stm32/stm32f407-st-discovery/packages/CMSIS-Core-latest
==============================> CMSIS-Core update done

/home/mhy/test/rt-thread/bsp/stm32/stm32f407-st-discovery/packages/stm32f4_hal_driver-latest
==============================> stm32f4_hal_driver update done

/home/mhy/test/rt-thread/bsp/stm32/stm32f407-st-discovery/packages/stm32f4_cmsis_driver-latest
==============================> stm32f4_cmsis_driver update done

Operation completed successfully.
mhy@chaselsv:~/test/rt-thread/bsp/stm32/stm32f407-st-discovery$ scons
scons: Reading SConscript files ...
Newlib version: 4.1.0
scons: done reading SConscript files.
scons: Building targets ...
scons: building associated VariantDir targets: build
CC build/applications/main.o
CC build/board/CubeMX_Config/Src/stm32f4xx_hal_msp.o
CC build/board/board.o
CC build/kernel/components/drivers/core/device.o
CC build/kernel/components/drivers/ipc/completion_comm.o
CC build/kernel/components/drivers/ipc/completion_up.o
CC build/kernel/components/drivers/ipc/condvar.o
CC build/kernel/components/drivers/ipc/dataqueue.o
CC build/kernel/components/drivers/ipc/pipe.o
CC build/kernel/components/drivers/ipc/ringblk_buf.o
CC build/kernel/components/drivers/ipc/ringbuffer.o
CC build/kernel/components/drivers/ipc/waitqueue.o
CC build/kernel/components/drivers/ipc/workqueue.o
CC build/kernel/components/drivers/pin/dev_pin.o
CC build/kernel/components/drivers/serial/dev_serial.o
CC build/kernel/components/finsh/cmd.o
CC build/kernel/components/finsh/msh.o
CC build/kernel/components/finsh/msh_parse.o
CC build/kernel/components/finsh/shell.o
CC build/kernel/components/libc/compilers/common/cctype.o
CC build/kernel/components/libc/compilers/common/cstdlib.o
CC build/kernel/components/libc/compilers/common/cstring.o
CC build/kernel/components/libc/compilers/common/ctime.o
CC build/kernel/components/libc/compilers/common/cunistd.o
CC build/kernel/components/libc/compilers/common/cwchar.o
CC build/kernel/components/libc/compilers/newlib/syscalls.o
CC build/kernel/libcpu/arm/common/atomic_arm.o
CC build/kernel/libcpu/arm/common/div0.o
CC build/kernel/libcpu/arm/common/showmem.o
AS build/kernel/libcpu/arm/cortex-m4/context_gcc.o
CC build/kernel/libcpu/arm/cortex-m4/cpuport.o
CC build/kernel/src/clock.o
CC build/kernel/src/components.o
CC build/kernel/src/cpu_up.o
CC build/kernel/src/defunct.o
CC build/kernel/src/idle.o
CC build/kernel/src/ipc.o
CC build/kernel/src/irq.o
CC build/kernel/src/klibc/kerrno.o
CC build/kernel/src/klibc/kstdio.o
CC build/kernel/src/klibc/kstring.o
CC build/kernel/src/klibc/rt_vsnprintf_tiny.o
CC build/kernel/src/klibc/rt_vsscanf.o
CC build/kernel/src/kservice.o
CC build/kernel/src/mem.o
CC build/kernel/src/mempool.o
CC build/kernel/src/object.o
CC build/kernel/src/scheduler_comm.o
CC build/kernel/src/scheduler_up.o
CC build/kernel/src/thread.o
CC build/kernel/src/timer.o
CC build/libraries/HAL_Drivers/drv_common.o
CC packages/stm32f4_cmsis_driver-latest/Source/Templates/system_stm32f4xx.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_cec.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_cortex.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_crc.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_cryp.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_cryp_ex.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_dma.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_dma_ex.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_gpio.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_pwr.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_pwr_ex.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_rcc.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_rcc_ex.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_rng.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_uart.o
CC packages/stm32f4_hal_driver-latest/Src/stm32f4xx_hal_usart.o
CC /home/mhy/test/rt-thread/bsp/stm32/libraries/HAL_Drivers/drivers/drv_gpio.o
CC /home/mhy/test/rt-thread/bsp/stm32/libraries/HAL_Drivers/drivers/drv_usart.o
LINK rt-thread.elf
/home/mhy/toolchains/gcc-arm-none-eabi-10.3-2021.10/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: warning: cannot find entry symbol Reset_Handler; defaulting to 0000000008000000
Memory region Used Size Region Size %age Used
CODE: 43448 B 1 MB 4.14%
RAM1: 3432 B 128 KB 2.62%
RAM2: 0 GB 64 KB 0.00%
arm-none-eabi-objcopy -O binary rt-thread.elf rtthread.bin
arm-none-eabi-size rt-thread.elf
text data bss dec hex filename
43448 1588 1844 46880 b720 rt-thread.elf
scons: done building targets.`

@kurisaW
Copy link
Member

kurisaW commented Jun 16, 2025

极有可能是scons版本语法的问题了，可能不支持这么写，我的是v4.8.1版本：

image

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 16, 2025

如果是版本的问题，要解决兼容性的吧，毕竟用户的环境都是不一样的

@kurisaW
Copy link
Member

kurisaW commented Jun 16, 2025

我们这边安排同事看看

@kurisaW kurisaW merged commit 652ad05 into RT-Thread-packages:master Jun 16, 2025
@kurisaW
Copy link
Member

kurisaW commented Jun 16, 2025

@Maihuanyi 感谢PR！另外作者能否帮忙把STM32全系列的CMSIS库都加上这一段配置？

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 16, 2025 via email

@kurisaW
Copy link
Member

kurisaW commented Jun 17, 2025

作者还有未合并的PR吗，可以在这个issue下评论，另外所有系列是否均已提交？有问题欢迎及时沟通

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 17, 2025 via email

@kurisaW
Copy link
Member

kurisaW commented Jun 17, 2025

PR链接在这发一下吧，我统一合并下

@Maihuanyi
Copy link
Author

Maihuanyi commented Jun 17, 2025

https://github.com/RT-Thread-packages/cmsis-device-wb/pull/2
https://github.com/RT-Thread-packages/cmsis-device-u5/pull/2
https://github.com/RT-Thread-packages/cmsis-device-l5/pull/2
https://github.com/RT-Thread-packages/stm32l4_cmsis_driver/pull/2
https://github.com/RT-Thread-packages/cmsis-device-h7rs
https://github.com/RT-Thread-packages/cmsis-device-h7/pull/2
https://github.com/RT-Thread-packages/cmsis-device-g4/pull/2
https://github.com/RT-Thread-packages/cmsis-device-g0/pull/2

@kurisaW
Copy link
Member

kurisaW commented Jun 17, 2025

所有相关PR均已合并，感谢作者贡献！期待您的下一次PR！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Maihuanyi @kurisaW