Skip to content

Conversation

@oxlm
Copy link
Contributor

@oxlm oxlm commented Feb 23, 2025

拉取/合并请求描述:(PR description)

[

FRDM-MCXA156

为什么提交这份PR (why to submit this PR)

  1. MCXA156 模板工程实际上是FRDM-MCXA153的工程,虽说不影响使用,但是从git diff上看,就会发现,默认的156在运行scons --target=mdk5后会变成153.
  2. 模板功臣默认的调试器未ulink,但实际上板载的调试器未cmsisdap,需要更改过来,否则每次生成工程都需要再次配置调试器

你的解决方案是什么 (what is your solution)

针对性修复问题

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • bsp\nxp\mcx\mcxa\frdm-mcxa156
  • .config:
    不需要修改
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [*] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [*] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [*] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [*] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [*] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [*] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [*] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [*] 代码是高质量的 Code in this PR is of high quality
  • [*] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • [*] 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@oxlm oxlm requested a review from Rbb666 as a code owner February 23, 2025 15:23
@github-actions github-actions bot added BSP: NXP Code related with NXP BSP labels Feb 23, 2025
@Rbb666 Rbb666 merged commit a7ba86e into RT-Thread:master Feb 24, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: NXP Code related with NXP BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants