Skip to content

Conversation

@RCSN
Copy link
Contributor

@RCSN RCSN commented Mar 4, 2025

[components][drivers][spi]: fix: set message.parent.next to NULL for rt_qspi_send_then_recv API and rt_qspi_send API

  • Ensure correct QSPI message chaining by setting next pointer to NULL, preventing unintended data transmission issues.

  • …t.next to NULL for qspi_read API

  • Ensure correct QSPI message chaining by setting next pointer to NULL, preventing unintended data transmission issues

为什么提交这份PR (why to submit this PR)

  • 在当前代码中,message只传输一次,message.parent.next 未被正确设置为 NULL,这可能导致消息链处理不正确,进而引发意外的数据传输问题。

你的解决方案是什么 (what is your solution)

  • 通过将 message.parent.next 设置为 NULL,可以确保 QSPI 消息的正确处理,避免这些问题。

  • BSP:

    • HPM5300EVK
  • .config:

  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2025

CLA assistant check
All committers have signed the CLA.

…rt_qspi_send_then_recv API and rt_qspi_send API

- Ensure correct QSPI message chaining by setting next pointer to NULL, preventing unintended data transmission issues.

Signed-off-by: Runcheng Lu <runcheng.lu@hpmicro.com>
@RCSN RCSN force-pushed the bugfix/fix_dev_qspi_core_message_next_issue branch from 4e9610b to e9daba6 Compare March 4, 2025 02:25
@Rbb666 Rbb666 merged commit ba50b60 into RT-Thread:master Mar 5, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants