Skip to content

Conversation

@1078249029
Copy link
Contributor

@1078249029 1078249029 commented Mar 6, 2025

It will be useful for quiting transmission mode of some chips like esp8266.

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#10081

你的解决方案是什么 (what is your solution)

Add formatting message function.

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

It will be useful for quiting transmission mode of some chips like esp8266.

Signed-off-by: 1078249029 <1078249029@qq.com>
@1078249029
Copy link
Contributor Author

components/net/at/src/at_utils.c实现可以再包装一层函数,这样看起来会更简单些,并且减少组件体积,代价是多了一次函数压栈出栈的消耗,请问一般这种情况下怎么处理?

@1078249029
Copy link
Contributor Author

@Rbb666 @supperthomas at组件并没有分配reviewer,二位谁能帮我review下?谢谢🙏

@supperthomas
Copy link
Member

在哪个bsp上验证的?可以加个yml吗?

@1078249029 1078249029 requested a review from supperthomas as a code owner March 7, 2025 01:21
@github-actions github-actions bot added the BSP label Mar 7, 2025
@supperthomas
Copy link
Member

image

@1078249029 1078249029 force-pushed the esp32_transmission_mode branch from 6f12653 to db632c5 Compare March 7, 2025 01:48
Signed-off-by: 1078249029 <1078249029@qq.com>
@1078249029 1078249029 force-pushed the esp32_transmission_mode branch from db632c5 to de5420d Compare March 7, 2025 02:04
@1078249029
Copy link
Contributor Author

@supperthomas 之前有个rtt的头文件没找到,更新工具链后就过ci了


DEVICE = ' -nostartfiles -march=rv32imc --specs=nosys.specs -fasynchronous-unwind-tables '
CFLAGS = DEVICE + '-gdwarf-4 -ggdb -Og '
CFLAGS = DEVICE + '-include ../../components/libc/compilers/common/include/sys/ioctl.h -gdwarf-4 -ggdb -Og '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPPPATH += [cwd + '/include/dfs_net']

试下在这里改。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@1078249029 1078249029 Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/RT-Thread/rt-thread/blob/master/components%2Flibc%2Fcompilers%2Fcommon%2FSConscript#L7-L7 或者看看这里头文件为啥没加进去

objs = PrepareBuilding(env, RTT_ROOT, remove_components = ['libc'])

这里在编译系统内把libc文件夹去掉了,如果添加后esp提供的工具链冲突
图片
所以只能在bsp内单独添加这个文件(添加文件夹也不行)。我上次报告的错误可能就是这个原因引起的
奇怪的是单独添加ioctl.h文件我的at代码竟然能用,不太了解sal层是怎么做的。

@1078249029 1078249029 requested a review from supperthomas March 7, 2025 08:44
@mysterywolf mysterywolf merged commit 72b9a10 into RT-Thread:master Mar 13, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants