-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[components][at] Add formatting message function for at client #10088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[components][at] Add formatting message function for at client #10088
Conversation
It will be useful for quiting transmission mode of some chips like esp8266. Signed-off-by: 1078249029 <1078249029@qq.com>
|
components/net/at/src/at_utils.c实现可以再包装一层函数,这样看起来会更简单些,并且减少组件体积,代价是多了一次函数压栈出栈的消耗,请问一般这种情况下怎么处理? |
|
@Rbb666 @supperthomas at组件并没有分配reviewer,二位谁能帮我review下?谢谢🙏 |
|
在哪个bsp上验证的?可以加个yml吗? |
6f12653 to
db632c5
Compare
Signed-off-by: 1078249029 <1078249029@qq.com>
db632c5 to
de5420d
Compare
|
@supperthomas 之前有个rtt的头文件没找到,更新工具链后就过ci了 |
|
|
||
| DEVICE = ' -nostartfiles -march=rv32imc --specs=nosys.specs -fasynchronous-unwind-tables ' | ||
| CFLAGS = DEVICE + '-gdwarf-4 -ggdb -Og ' | ||
| CFLAGS = DEVICE + '-include ../../components/libc/compilers/common/include/sys/ioctl.h -gdwarf-4 -ggdb -Og ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rt-thread/components/net/sal/SConscript
Line 26 in 17d41e7
| CPPPATH += [cwd + '/include/dfs_net'] |
试下在这里改。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/RT-Thread/rt-thread/blob/master/components%2Flibc%2Fcompilers%2Fcommon%2FSConscript#L7-L7 或者看看这里头文件为啥没加进去
rt-thread/bsp/ESP32_C3/SConstruct
Line 61 in b506228
| objs = PrepareBuilding(env, RTT_ROOT, remove_components = ['libc']) |
这里在编译系统内把libc文件夹去掉了,如果添加后esp提供的工具链冲突

所以只能在bsp内单独添加这个文件(添加文件夹也不行)。我上次报告的错误可能就是这个原因引起的
奇怪的是单独添加
ioctl.h文件我的at代码竟然能用,不太了解sal层是怎么做的。

It will be useful for quiting transmission mode of some chips like esp8266.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
#10081
你的解决方案是什么 (what is your solution)
Add formatting message function.
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up