Skip to content

Conversation

@CYFS3
Copy link
Contributor

@CYFS3 CYFS3 commented Mar 14, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#9165

你的解决方案是什么 (what is your solution)

使用旧的api

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CYFS3 CYFS3 requested a review from Rbb666 as a code owner March 14, 2025 09:11
@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels Mar 14, 2025
@CYFS3 CYFS3 force-pushed the artpi_phy_fix branch 2 times, most recently from 65732aa to 1316ae4 Compare March 14, 2025 09:42
@Rbb666
Copy link
Member

Rbb666 commented Mar 15, 2025

格式化下,另外这个PR有在ARTPI上验证过吗

@CYFS3
Copy link
Contributor Author

CYFS3 commented Mar 15, 2025

格式化下,另外这个PR有在ARTPI上验证过吗

有的在板端验证过了

src = Glob('board.c')
src += Glob('CubeMX_Config/Core/Src/stm32h7xx_hal_msp.c')

src += Glob('port/drv_mpu.c')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里要加mpu的宏

@supperthomas
Copy link
Member

artpi最好加个yml说明一下如何使用

@CYFS3
Copy link
Contributor Author

CYFS3 commented Mar 16, 2025

artpi最好加个yml说明一下如何使用

已添加

@supperthomas
Copy link
Member

image
CI的问题。

@supperthomas
Copy link
Member

不需要的kconfig或者没有验证过的kconfig可以不用加。

@supperthomas supperthomas added the +1 Agree +1 label Mar 16, 2025
@Rbb666 Rbb666 merged commit a88c5d0 into RT-Thread:master Mar 17, 2025
54 checks passed
@Rbb666 Rbb666 added the 5.2.0 version 5.2.0 (planned to be released by the end of 2025) label Mar 17, 2025
@CYFS3 CYFS3 deleted the artpi_phy_fix branch March 17, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.2.0 version 5.2.0 (planned to be released by the end of 2025) BSP: STM32 BSP related with ST/STM32 BSP +1 Agree +1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants