Skip to content

Conversation

@supperthomas
Copy link
Member

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@supperthomas supperthomas requested a review from Rbb666 as a code owner March 27, 2025 14:09
@supperthomas supperthomas requested review from Copilot and removed request for Rbb666 March 27, 2025 14:09
@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels Mar 27, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds BTstack configuration support for the stm32h750-artpi BSP.

  • Added a new BTstack configuration block in the CI attachconfig YAML file.
  • Enabled UART3 along with several BTstack-related configuration options.
Files not reviewed (1)
  • bsp/stm32/stm32h750-artpi/template.uvprojx: Language not supported

@supperthomas supperthomas reopened this Mar 27, 2025
@supperthomas supperthomas requested a review from Copilot March 27, 2025 14:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds BTstack support to the stm32h750-artpi BSP by updating the attachconfig YAML file with new Kconfig entries.

  • Adds a new package entry "package.iot.btstack" with BTstack-related configuration settings.
  • Introduces configuration keys to enable UART3 and various BTstack features.
Files not reviewed (1)
  • bsp/stm32/stm32h750-artpi/template.uvprojx: Language not supported
Comments suppressed due to low confidence (1)

bsp/stm32/stm32h750-artpi/.ci/attachconfig/ci.attachconfig.yml:26

  • [nitpick] The naming of 'CONFIG_PKG_BTSTACK_SAMPLE_LE_COUNTER' is inconsistent with other BTstack config keys that use the 'USING' prefix. Consider renaming it to 'CONFIG_PKG_USING_BTSTACK_SAMPLE_LE_COUNTER' to improve clarity.
- CONFIG_PKG_BTSTACK_SAMPLE_LE_COUNTER=y

@mysterywolf mysterywolf merged commit 1bb18f6 into RT-Thread:master Mar 28, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants