Skip to content

Conversation

@messigogogo
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

1.修改config适配方式,符合最新的ci框架

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP BSP: Phytium BSP related with Phytium labels Apr 14, 2025
@messigogogo
Copy link
Contributor Author

messigogogo commented Apr 14, 2025

编译链不可以根据rt-smart配置切换吗,似乎rtsmart配置编译不过去?@supperthomas

@supperthomas
Copy link
Member

编译链不可以根据rt-smart配置切换吗,似乎rtsmart配置编译不过去?@supperthomas

rtsmart
toolchain不一样吗?那估计不行了,那你先smart配置保留之前的吧,rtthread的用yml

@supperthomas
Copy link
Member

smart部分后面再想办法吧。目前只支持rt-thread

CONFIG_RT_USING_RTC=y
# CONFIG_RT_USING_PIN is not set
CONFIG_RT_USING_POSIX_FS=y
CONFIG_RT_USING_POSIX_TERMIOS=y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件不用加,
一些用户可以自己生成的文件,比如.config, rtconfig.h不用每次都加。不需要,可以删除,保留最基本的常用配置即可。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,这个pr先放一下,后面再解决

@supperthomas
Copy link
Member

两个环境会相互干扰吗?不干扰,可以先弄好。

wget -q https://github.com/RT-Thread/toolchains-ci/releases/download/v1.6/gcc-arm-10.2-2020.11-x86_64-aarch64-none-elf.tar.xz

试试在这里先把环境弄好,

@messigogogo messigogogo reopened this Apr 15, 2025
@messigogogo
Copy link
Contributor Author

messigogogo commented Apr 15, 2025

两个环境会相互干扰吗?不干扰,可以先弄好。

wget -q https://github.com/RT-Thread/toolchains-ci/releases/download/v1.6/gcc-arm-10.2-2020.11-x86_64-aarch64-none-elf.tar.xz

试试在这里先把环境弄好,

主要是 ALL_BSP_COMPILE.json里面一个 “RTT_TOOL_CHAIN”下面对应的是一个路径。32位和64位,加上thread和smart需要4个不同的编译链,最好ci能根据宏定义切一下编译链。不然全分开也是很冗余。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Phytium BSP related with Phytium BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants