Skip to content

Conversation

@Passionate0424
Copy link
Contributor

@Passionate0424 Passionate0424 commented Apr 24, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

修改ifx_pin_irq_enable中断号不正确问题

你的解决方案是什么 (what is your solution)

将IRQn_Type irqn = (IRQn_Type)(irqmap->irqno + PORT_GET(irqmap->port));改为IRQn_Type irqn = irqmap->irqno;

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

Passionate0424 and others added 2 commits April 24, 2025 11:08
@github-actions github-actions bot added BSP BSP: Infineon BSP related with Infineon labels Apr 24, 2025
@supperthomas supperthomas requested a review from Copilot April 30, 2025 01:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an incorrect interrupt number computation in the ifx_pin_irq_enable function. It removes the unintentional addition of the port offset by eliminating the PORT_GET call in two places.

  • Removed the unnecessary addition to the IRQ number.
  • Updated both the initialization and de-initialization sections for consistent IRQ handling.

IRQn_Type irqn = (IRQn_Type)(irqmap->irqno + PORT_GET(irqmap->port));
IRQn_Type irqn = irqmap->irqno;
irq_cb_data[irqn].callback = irq_callback;
irq_cb_data[irqn].callback_arg = (rt_uint16_t *)&pin_irq_map[gpio_port].port;
Copy link

Copilot AI Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eliminating the addition of PORT_GET (irqmap->port) ensures that the correct IRQ number is used during IRQ initialization.

Suggested change
irq_cb_data[irqn].callback_arg = (rt_uint16_t *)&pin_irq_map[gpio_port].port;
irq_cb_data[irqn].callback_arg = (rt_uint16_t *)&irqmap->port; // Directly use irqmap->port

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不必要修改

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@supperthomas
Copy link
Member

标题改一下

@Passionate0424 Passionate0424 changed the title Dev fix ifx_pin_irq_enable May 1, 2025
@Rbb666 Rbb666 merged commit 3fb3be8 into RT-Thread:master May 10, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Infineon BSP related with Infineon BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants