Skip to content

Conversation

@hydevcode
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

添加xmc7100d-f144k4160aa的外设适配

你的解决方案是什么 (what is your solution)

使能正常读取tf卡和板载IMU

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/Infineon/xmc7100d-f144k4160aa
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP BSP: Infineon BSP related with Infineon labels Apr 27, 2025
@supperthomas supperthomas requested a review from Copilot April 27, 2025 06:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds peripheral support for the Infineon XMC7100D-F144K4160AA board by enabling SPI flash initialization and TF card filesystem mounting, as well as updating SPI driver support. Key changes include:

  • Adding a new SPI flash initialization module.
  • Implementing a filesystem mount routine for TF card support.
  • Updating SConscript files and SPI driver configuration to include support for additional SPI buses.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
bsp/Infineon/xmc7100d-f144k4160aa/board/ports/spi_flash_init.c Introduces SPI flash initialization and device attachment.
bsp/Infineon/xmc7100d-f144k4160aa/board/ports/drv_filesystem.c Adds filesystem mounting functionality for TF card usage.
bsp/Infineon/xmc7100d-f144k4160aa/board/ports/SConscript Updates driver file globs based on BSP configuration.
bsp/Infineon/xmc7100d-f144k4160aa/board/SConscript Dynamically includes subdirectories with SConscript files.
bsp/Infineon/xmc7100d-f144k4160aa/.ci/attachconfig/ci.attachconfig.yml Adds CI configuration for TF card and QMI8658 peripherals.
bsp/Infineon/libraries/HAL_Drivers/drv_spi.c Adds support for the SPI5 bus in the SPI driver.
Files not reviewed (1)
  • bsp/Infineon/xmc7100d-f144k4160aa/board/Kconfig: Language not supported
Comments suppressed due to low confidence (1)

bsp/Infineon/xmc7100d-f144k4160aa/board/SConscript:61

  • [nitpick] Consider renaming the variable 'list' to avoid shadowing the built-in Python type and improve code clarity, such as using 'files' instead.
list = os.listdir(cwd)

@Rbb666 Rbb666 merged commit b4e051a into RT-Thread:master Apr 27, 2025
34 checks passed
@hydevcode hydevcode deleted the xmc7100d_per branch April 27, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Infineon BSP related with Infineon BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants