Skip to content

Conversation

@unicornx
Copy link
Contributor

@unicornx unicornx commented Apr 27, 2025

原先打包内核的方法需要依赖于安装 K230 RTOS SDK。比较繁琐,现将相关逻辑抽取出来开发了一个小的工具 rttpkgtool 对内核 rtthread.bin 进行打包。

考虑到目前 rttpkgtool 对 k230 打包时依然依赖于要编译 opensbi,这意味着需要安装单独的交叉工具链。所以为了不影响 CI 运行,目前打包的逻辑没有集成为 rtconfig.py 中的 POST_ACTION,而是要求内核开发人员单独运行 build.sh 脚本进行打包。

删除了 mkfm.sh 脚本,因为被 rttpkgtool 代替了。

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the BSP label Apr 27, 2025
@unicornx unicornx added Arch: RISC-V BSP related with risc-v BSP: K230 BSP related with K230 and removed BSP labels Apr 27, 2025
@supperthomas supperthomas requested a review from Copilot April 27, 2025 07:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the BSP documentation for the K230 board by replacing the old packaging script (mkfm.sh) with a new tool (rttpkgtool) and corresponding helper scripts (build.sh and sdcard.sh) to simplify kernel packaging.

  • Updated the Table of Contents and section numbering to reflect the new packaging process.
  • Added detailed instructions on using build.sh and sdcard.sh for kernel image generation and flashing.
  • Removed outdated instructions related to mkfm.sh and the old flashing methods.
Files not reviewed (3)
  • bsp/k230/.gitignore: Language not supported
  • bsp/k230/build.sh: Language not supported
  • bsp/k230/mkfm.sh: Language not supported
Comments suppressed due to low confidence (1)

bsp/k230/README.md:212

  • Consider correcting '01Studo' to '01Studio' to match the expected board name.
将 SD 卡插入 01Studo 开发板的 SD 卡槽。

The original method of packaging and burning kernel
depends on installing the K230 RTOS SDK. It is quite
cumbersome. Now the relevant logic is extracted and
a small tool rttpkgtool is created to package the
rtthread.bin.

Considering that rttpkgtool still needs to compile
opensbi when packaging k230, which means that a
separate cross-toolchain needs to be installed.
Therefore, in order not to affect the CI operation,
the current packaging logic is not integrated into
POST_ACTION in rtconfig.py, but requires kernel
developers to run the build script separately for
packaging.

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
@unicornx unicornx force-pushed the dev-k230-rttpkgtool branch from 6839f8e to caf8e67 Compare April 27, 2025 08:03
@github-actions github-actions bot added the BSP label Apr 27, 2025
@unicornx
Copy link
Contributor Author

Pull Request Overview

This PR refactors the BSP documentation for the K230 board by replacing the old packaging script (mkfm.sh) with a new tool (rttpkgtool) and corresponding helper scripts (build.sh and sdcard.sh) to simplify kernel packaging.

  • Updated the Table of Contents and section numbering to reflect the new packaging process.
  • Added detailed instructions on using build.sh and sdcard.sh for kernel image generation and flashing.
  • Removed outdated instructions related to mkfm.sh and the old flashing methods.

Files not reviewed (3)
Comments suppressed due to low confidence (1)
bsp/k230/README.md:212

  • Consider correcting '01Studo' to '01Studio' to match the expected board name.
将 SD 卡插入 01Studo 开发板的 SD 卡槽。

Fixed.

@unicornx unicornx requested a review from Rbb666 April 27, 2025 08:22
@Rbb666 Rbb666 merged commit e08fc29 into RT-Thread:master Apr 28, 2025
34 checks passed
@unicornx unicornx deleted the dev-k230-rttpkgtool branch May 7, 2025 03:07
@Rbb666 Rbb666 mentioned this pull request Sep 18, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: RISC-V BSP related with risc-v BSP: K230 BSP related with K230 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants