Skip to content

Fixing comments errors of RT_WLAN_EVT_SCAN_DONE and RT_WLAN_EVT_SCAN_REPORT #10237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supperthomas merged 3 commits into from
Apr 29, 2025
Merged

Fixing comments errors of RT_WLAN_EVT_SCAN_DONE and RT_WLAN_EVT_SCAN_REPORT #10237

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd3b912
include ：rtdef.h : [ Refine the annotation of RT_ALIGN and RT_ALIGN_D…
Apr 18, 2025
b11870a
Merge branch 'master' of https://github.com/illustriousness/rt-thread
Apr 28, 2025
e84728a
<components>:drivers\wlan\dev_wlan_mgnt.h: [ Fixing comments errors o…
Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/drivers/wlan/dev_wlan_mgnt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ extern "C" {
typedef enum
{
RT_WLAN_EVT_READY = 0, /* connect and prot is ok, You can send data*/
RT_WLAN_EVT_SCAN_DONE, /* Scan a info */
RT_WLAN_EVT_SCAN_REPORT, /* Scan end */
RT_WLAN_EVT_SCAN_DONE, /* Scan end */
RT_WLAN_EVT_SCAN_REPORT, /* Scan a info */
Copy link

Copilot AI Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider revising the comment 'Scan a info' for RT_WLAN_EVT_SCAN_REPORT for improved clarity, such as 'Scan information available', if that better describes the event.

Suggested change
RT_WLAN_EVT_SCAN_REPORT, /* Scan a info */
RT_WLAN_EVT_SCAN_REPORT, /* Scan information available */

Copilot uses AI. Check for mistakes.
RT_WLAN_EVT_STA_CONNECTED, /* connect success */
RT_WLAN_EVT_STA_CONNECTED_FAIL, /* connection failed */
RT_WLAN_EVT_STA_DISCONNECTED, /* disconnect */
Expand Down