Skip to content

Conversation

@unicornx
Copy link
Contributor

@unicornx unicornx commented May 7, 2025

在 bsp/k230 中如果运行 kconfig, 会看到下面和 bsp 相关的告警:

Kconfig:5: warning: BSP_ROOT has 'option env="BSP_DIR"',... 
Kconfig:10: warning: RTT_ROOT has 'option env="RTT_DIR"',... 
Kconfig:15: warning: PKGS_ROOT has 'option env="PKGS_DIR"',...
...
warning: the choice symbol PKG_USING_ZLIB_LATEST_VERSION (...) is selected by the following symbols, but select/imply has no effect on choice symbols
 - BSP_ROOTFS_TYPE_CROMFS (defined at Kconfig:41) warning: the value '0xF00000000' is invalid for C908_PLIC_PHY_ADDR...

这个 pr 将清除这些告警。

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

When run kconfig, see warnings as followings:

Kconfig:5: warning: BSP_ROOT has 'option env="BSP_DIR"',...
Kconfig:10: warning: RTT_ROOT has 'option env="RTT_DIR"',...
Kconfig:15: warning: PKGS_ROOT has 'option env="PKGS_DIR"',...
...
warning: the choice symbol PKG_USING_ZLIB_LATEST_VERSION (...)
is selected by the following symbols, but select/imply has no
effect on choice symbols
 - BSP_ROOTFS_TYPE_CROMFS (defined at Kconfig:41)
warning: the value '0xF00000000' is invalid for C908_PLIC_PHY_ADDR...

Trying to cleanup Kconfig and re-run menuconfig to update.

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
@github-actions github-actions bot added the BSP label May 7, 2025
@unicornx unicornx added the BSP: K230 BSP related with K230 label May 7, 2025
@unicornx unicornx requested a review from Rbb666 May 7, 2025 03:26
@Rbb666 Rbb666 merged commit 3777ac1 into RT-Thread:master May 7, 2025
34 checks passed
@unicornx unicornx deleted the dev-cleanup-warnings-kconfig branch May 14, 2025 08:20
@Rbb666 Rbb666 mentioned this pull request Sep 18, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: K230 BSP related with K230 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants