Skip to content

Conversation

@MouriNaruto
Copy link
Contributor

@MouriNaruto MouriNaruto commented May 9, 2025

拉取/合并请求描述:(PR description)

  • Add x86 Release, x64 Debug, and x64 Release to the Visual Studio 2012 project template.
  • Tidy the Visual Studio 2012 project template.
  • Update SDL2 Windows prebuilt binaries to 2.32.6 with x86 and x64 binaries.

image

Finally, we can happy with MSVC x64 Release, lol.

Kenji Mouri

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the BSP label May 9, 2025
@Rbb666
Copy link
Member

Rbb666 commented May 10, 2025

@ComerLater 能帮忙review下这个PR吗~

@BernardXiong BernardXiong added the +1 Agree +1 label May 10, 2025
@supperthomas supperthomas merged commit 74245ed into RT-Thread:master May 12, 2025
34 checks passed
@MouriNaruto MouriNaruto deleted the improve_simulator_vs2012_project branch May 12, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP +1 Agree +1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants