Skip to content

drivers/bsp：synchronize the relevant serial_v2 driver configuration items #10263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rbb666 merged 1 commit into from
May 16, 2025
Merged

drivers/bsp：synchronize the relevant serial_v2 driver configuration items #10263

Rbb666 merged 1 commit into from
May 16, 2025

Conversation

@Ryan-CW-Code
Copy link
Contributor

@Ryan-CW-Code Ryan-CW-Code commented May 12, 2025

拉取/合并请求描述：(PR description)

#9389 PR的更新提交
[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@Ryan-CW-Code
Copy link
Contributor Author

Ryan-CW-Code commented May 14, 2025

stm32F407的utest截图
image

stm32F401我们多个产品一直在用at_socket

@hydevcode
Copy link
Contributor

hydevcode commented May 14, 2025

这边尝试了分别使用etherkit，rt-spark，ART-PI，HPM5301，qemu-vexpress-a9跑了一遍测试样例，都没有问题

@Ryan-CW-Code @hydevcode
[drivers][serial_v2]允许阻塞接收超过rx缓冲区大小的数据、增加超时时间、flush、获取缓冲区数据长度命令、数据溢出逻…
503cb0e 
…辑修复、稳定性细节优化、添加更多serial_v2测试用例

[components][serial_v2] 优化txflush逻辑、对tx的activated做中断保护

[components][at] at_client适配新版serial_v2

[components][at] at_server适配新版serial_v2

[components][serial_v2] 测试用例增加循环调用，format测试用例

[components][serial_v2] poll模式判断逻辑错误

[components][serial_v2] 测试用例去掉一些非必要延时

[components][serial_v2] 测试例程使用menuconfig进行配置，更新readme

[components][at_client] at_client_getchar返回值错误、at_client解析线程优先级错误设置

[components][at] 错误码应该返回负值

[components][serial_v2] TCFLSH和FIONREAD完善、control函数增加错误返回值

[components][serial_v2] RT_SERIAL_CTRL_GET_RX_DATA_LEN更改为RT_SERIAL_CTRL_GET_UNREAD_BYTES_COUNT

[utest][serial_v2] TC_UART_SEND_TIMES替换为RT_SERIAL_TC_SEND_ITERATIONS

[components][serial_v2] FIONREAD参数应该是无符号类型

[utest][serial_v2] 完善测试用例

[components][serial_v2] 避免使用三目运算符

[components][serial_v2] 使用clang-format格式化代码

[components][serial_v2] 添加get超时时间命令

[components][serial_v2] 完善posix接口

[components][serial_v2] 阻塞接口添加阻塞时间为0时的处理逻辑、优化RX阻塞接收逻辑

[components][serial_v2] 设置超时时间命令的参数改为指针形式

[components][serial_v2] nbuf发送添加超时时间为0时的逻辑

[components][serial_v2] 完善添加测试用例

[utest][serial_v2] 修复依赖关系

[components][serial_v2] 非阻塞模式下tx_flush错误修复

[components][serial_v2] activated使用原子API

[components][serial_v2] 优化DMA逻辑、没使能DMA时屏蔽DMA逻辑节约资源

[components][serial_v2] 提供写满时丢弃新数据和覆盖旧数据策略，写满丢弃策略效率更高

[components][serial_v2] 部分平台适配写满时两种策略功能

[components][serial_v2] DMA模式暂不支持丢弃新数据策略

[utest][serial_v2] 优化测试代码

[components][serial_v2] DMA模式下使用乒乓缓冲、DMA模式支持丢弃新数据策略

[utest][serial_v2] 适配DMA乒乓缓冲

[bsp][serial_v2] 部分bsp适配DMA下乒乓缓冲

[components][serial_v2] 使用spinlock替换中断，对部分结构体变量使用原子操作

[utest][serial_v2] 更新测试用例

[components][at] 适配new serialv2不再判断RTT版本号

[components][at] 删除多余的中文注释

[utest][serial_v2] 添加交叉echo示例，qemu环境下专用

[bsp][qemu] 适配串口v2并开启fifo

[components][at] 修复合并导致的错误

[bsp][n32] 适配serial_v2，没有经过测试

[components][serial_v2] 格式化代码

[utest][serial_v2] 删除无意义的打印
@Rbb666
Copy link
Member

Rbb666 commented May 15, 2025

@Ryan-CW-Code Hi，感谢PR，请问下Serial V2的维护者是否可以设置给您？

@Ryan-CW-Code
Copy link
Contributor Author

Ryan-CW-Code commented May 15, 2025

@Ryan-CW-Code Hi，感谢PR，请问下Serial V2的维护者是否可以设置给您？

可以

@Rbb666
Copy link
Member

Rbb666 commented May 15, 2025

@Ryan-CW-Code Hi，感谢PR，请问下Serial V2的维护者是否可以设置给您？

可以

可以在这个文件中补充下您的信息，这样下次有人修改目标路径下的文件，ci会提醒你：https://github.com/RT-Thread/rt-thread/blob/master/MAINTAINERS

@Ryan-CW-Code
Copy link
Contributor Author

Ryan-CW-Code commented May 15, 2025

#10279 添加维护者PR

@Rbb666 Rbb666 closed this May 15, 2025
@Rbb666 Rbb666 reopened this May 15, 2025
@Rbb666
Copy link
Member

Rbb666 commented May 15, 2025

@kurisaW 为啥这个没触发MAINTAINERS的ci评论呢？

@kurisaW
Copy link
Member

kurisaW commented May 15, 2025

涉及到的文件变更不属于审查内容

image

@kurisaW
Copy link
Member

kurisaW commented May 15, 2025

@Ryan-CW-Code 麻烦作者重新修改下MAINTAINERS，按照字母顺序填写审查项

image

@kurisaW
Copy link
Member

kurisaW commented May 15, 2025

pr标题建议修改为：drivers/bsp：synchronize the relevant serial_v2 driver configuration items

@Ryan-CW-Code Ryan-CW-Code changed the title Serial v2 new drivers/bsp：synchronize the relevant serial_v2 driver configuration items May 16, 2025
@Rbb666 Rbb666 merged commit ac8fba0 into RT-Thread:master May 16, 2025
79 checks passed
@cc-caixf
Copy link
Contributor

cc-caixf commented May 17, 2025 •
edited
Loading

@Ryan-CW-Code 你好
这里的 dma_ping_rb 可以改成数组吗, 不用套一个ringbuf, 效率更高

@Ryan-CW-Code
Copy link
Contributor Author

Ryan-CW-Code commented May 17, 2025

@Ryan-CW-Code 你好 这里的 dma_ping_rb 可以改成数组吗, 不用套一个ringbuf, 效率更高

感谢提供思路
理论上是可以的，周一我跑utest测试一下。

@hydevcode hydevcode deleted the serial_v2_new branch June 16, 2025 01:34
@Ryan-CW-Code Ryan-CW-Code mentioned this pull request Jul 25, 2025
Open
2 tasks
This was referenced Sep 28, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes

@mysterywolf mysterywolf Awaiting requested review from mysterywolf mysterywolf is a code owner

Assignees

No one assigned

Labels

BSP: AT32 BSP related with AT32 BSP: GD32 BSP related with GD32 BSP: Renesas BSP related with Renesas BSP: STM32 BSP related with ST/STM32 BSP component: drivers/serial component: drivers component: net/at component: net Component testcase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ryan-CW-Code @hydevcode @Rbb666 @kurisaW @cc-caixf