Skip to content

Conversation

@unicornx
Copy link
Contributor

每个entry必须以 tag 为关键字按照英文字母表顺序排序。这样以后 entry 多了方便查找。

而且这一般也是使用英文的惯例,按照字母表排序也比较美观。

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

Each entry must be sorted in alphabetical order with
tag as the keyword. This makes it easier for searching
when there are more entries in the future.

And this is also a common practice in English, and
alphabetical sorting is also more beautiful.

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
@unicornx unicornx requested a review from supperthomas May 13, 2025 02:35
@unicornx
Copy link
Contributor Author

@kurisaW 请 review。另外请问为啥这个 CI Check 会fail?

@unicornx unicornx requested a review from Rbb666 May 13, 2025 02:38
@kurisaW
Copy link
Member

kurisaW commented May 13, 2025

@kurisaW 请 review。另外请问为啥这个 CI Check 会fail?

好的我看看

@kurisaW
Copy link
Member

kurisaW commented May 13, 2025

等待该PR合并后重新运行ci即可:

@Rbb666 Rbb666 closed this May 13, 2025
@Rbb666 Rbb666 reopened this May 13, 2025
@unicornx
Copy link
Contributor Author

@Rbb666 ci check passed, can you please review and merge?
@kurisaW do you have any comment on this? I can not add you as reviewer, but I hope you have a look at this.

@kurisaW
Copy link
Member

kurisaW commented May 13, 2025

lgtm

@Rbb666 Rbb666 merged commit e48d76d into RT-Thread:master May 13, 2025
113 of 115 checks passed
@unicornx unicornx deleted the dev-maintainer-sort branch May 13, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants