Skip to content

Conversation

@Yaochenger
Copy link
Contributor

@Yaochenger Yaochenger commented May 14, 2025

拉取/合并请求描述:(PR description)

为什么提交这份PR (why to submit this PR)

  • 添加玄铁E906系列内核的适配

请提供验证的bsp和config (provide the config and bsp)

  • BSP:bsp\xuantie\smartl\e906

请提供自己仓库的PR branch的action的编译链接相关PR文件成功的链接:

https://github.com/Yaochenger/rt-thread/tree/xuantie_e906

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@Yaochenger Yaochenger changed the title [add] add xuantie e906 series bsp [bsp] add xuantie e906 series bsp May 14, 2025
@supperthomas
Copy link
Member

如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@Rbb666
Copy link
Member

Rbb666 commented May 14, 2025

@Yaochenger CI看护加也一下吧

@Rbb666 Rbb666 self-requested a review May 14, 2025 07:01
@Rbb666 Rbb666 added the Arch: RISC-V BSP related with risc-v label May 14, 2025
@unicornx
Copy link
Contributor

天啊,哪里来的代码,岂止是 e906,我看 arch 下包括了整个 玄铁系列。整个 pr 和 libcpu 下的 riscv 有重叠部分吗?

@Rbb666
Copy link
Member

Rbb666 commented May 14, 2025

天啊,哪里来的代码,岂止是 e906,我看 arch 下包括了整个 玄铁系列。整个 pr 和 libcpu 下的 riscv 有重叠部分吗?

和玄铁的合作,后面会把玄铁的C,R,E都适配到主线

@Yaochenger Yaochenger requested a review from supperthomas as a code owner May 14, 2025 08:54
@github-actions github-actions bot added the action github action yml imporve label May 14, 2025
@github-actions
Copy link

github-actions bot commented May 14, 2025

📌 Code Review Assignment

🏷️ Tag: workflow

Path: .github
Reviewers: supperthomas Rbb666 kurisaW

Changed Files (Click to expand)
  • .github/ALL_BSP_COMPILE.json
  • .github/workflows/bsp_buildings.yml

📊 Current Review Status (Last Updated: 2025-05-14 09:08 UTC)

  • Rbb666 Pending Review
  • kurisaW Pending Review
  • supperthomas Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Yaochenger
Copy link
Contributor Author

天啊,哪里来的代码,岂止是 e906,我看 arch 下包括了整个 玄铁系列。整个 pr 和 libcpu 下的 riscv 有重叠部分吗?

陆续E,R,C全系列都会支持rt-thread,代码会按照当前结构去添加,当前pr的libcpu使用的是riscv/common中的文件,该pr不涉及libcpu的修改

Copy link
Member

@supperthomas supperthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议参考#9960
https://club.rt-thread.org/ask/article/4839095b91c2f849.html
把library放到软件包。

@unicornx
Copy link
Contributor

天啊,哪里来的代码,岂止是 e906,我看 arch 下包括了整个 玄铁系列。整个 pr 和 libcpu 下的 riscv 有重叠部分吗?

和玄铁的合作,后面会把玄铁的C,R,E都适配到主线

所以以后 libcpu 下 riscv 中的 thread 部分都会被废弃掉吗?

@Yaochenger
Copy link
Contributor Author

建议参考#9960 https://club.rt-thread.org/ask/article/4839095b91c2f849.html 把library放到软件包。

Uploading image.png… 这个目前占用量不大,后续还会移除部分内容,暂时先放在BSP中了。

@supperthomas supperthomas merged commit 3775ea0 into RT-Thread:master May 14, 2025
59 checks passed
@Yaochenger Yaochenger deleted the xuantie_e906 branch July 3, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action github action yml imporve Arch: RISC-V BSP related with risc-v BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants