Skip to content

Conversation

@kurisaW
Copy link
Member

@kurisaW kurisaW commented May 15, 2025

拉取/合并请求描述:(PR description)

[

ab32vg1 支持GPIO中断

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the BSP label May 15, 2025
@kurisaW kurisaW marked this pull request as draft May 15, 2025 08:17
@kurisaW kurisaW marked this pull request as ready for review May 15, 2025 08:19
@supperthomas supperthomas requested a review from Copilot May 15, 2025 08:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GPIO interrupt support for the ab32vg1 board, enabling enhanced interrupt handling via new wakeup circuitry.

  • Added a new IRQ constant for GPIO interrupts.
  • Introduced wakeup interrupt macros and an IRQ structure in drv_gpio.h.
  • Refactored IRQ attach, detach, and handler functions in drv_gpio.c to support GPIO interrupts.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
bsp/bluetrum/libraries/hal_libraries/bmsis/include/ab32vg1.h Added new GPIO IRQ enum constant.
bsp/bluetrum/libraries/hal_drivers/drv_gpio.h Added wakeup interrupt macros and a structure to store IRQ handlers.
bsp/bluetrum/libraries/hal_drivers/drv_gpio.c Implemented new functions for interrupt attach/detach and handling for GPIO interrupts.

@kurisaW kurisaW marked this pull request as draft May 15, 2025 09:45
@kurisaW
Copy link
Member Author

kurisaW commented May 15, 2025

主线5.2.1版本标准版已经不适合该系列BSP正常运行,建议根据需求进行裁剪,可作为参考设计保留

image

@kurisaW kurisaW marked this pull request as ready for review May 15, 2025 10:25
@supperthomas supperthomas merged commit 05699d6 into RT-Thread:master May 15, 2025
34 checks passed
@kurisaW kurisaW deleted the gpio_irq branch May 29, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants