-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[dfs] enable procfs and tempfs in default when using smart; fix LWIP_… #10292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ROUTE warning issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables procfs and tmpfs by default for smart configurations and fixes a route warning by conditionally compiling the route_show function when LWIP_ROUTE is defined.
- Enable proc file system by changing its default to "yes"
- Enable TMP file system and MQUEUE conditionally for smart configurations
- Add conditional compilation for the route_show function to fix route warnings
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| components/dfs/dfs_v2/filesystems/procfs/proc_net.c | Wrapped route_show in conditional compilation for LWIP_ROUTE |
| components/dfs/Kconfig | Updated defaults for procfs, tmpfs, and mqueue under RT_USING_SMART |
| return NULL; | ||
| } | ||
|
|
||
| #if LWIP_ROUTE |
Copilot
AI
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider adding a comment explaining that the route_show function is conditionally compiled based on the LWIP_ROUTE flag to clarify its dependency for future maintainers.
| config RT_USING_DFS_PROCFS | ||
| bool "Enable proc file system" | ||
| default n | ||
| default y |
Copilot
AI
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Update for RT_USING_DFS_PROCFS default is appropriate; however, add an inline comment explaining that enabling procfs by default under smart is intentional to improve maintainability.
|
|
||
| config RT_USING_DFS_TMPFS | ||
| bool "Enable TMP file system" | ||
| default y if RT_USING_SMART |
Copilot
AI
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] For clarity, consider including a comment that details why TMPFS (and similarly MQUEUE on line 213) is conditionally enabled when using smart configurations.
…ROUTE warning issue.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
在smart下默认procfs并未打开;
你的解决方案是什么 (what is your solution)
修改Kconfig配置,在smart下默认打开procfs,tmpfs等。并修正route_show警告。
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up