Skip to content

Conversation

@BernardXiong
Copy link
Member

…ROUTE warning issue.

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

在smart下默认procfs并未打开;

你的解决方案是什么 (what is your solution)

修改Kconfig配置,在smart下默认打开procfs,tmpfs等。并修正route_show警告。

请提供验证的bsp和config (provide the config and bsp)

  • BSP: qemu-virt64-aarch64
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables procfs and tmpfs by default for smart configurations and fixes a route warning by conditionally compiling the route_show function when LWIP_ROUTE is defined.

  • Enable proc file system by changing its default to "yes"
  • Enable TMP file system and MQUEUE conditionally for smart configurations
  • Add conditional compilation for the route_show function to fix route warnings

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
components/dfs/dfs_v2/filesystems/procfs/proc_net.c Wrapped route_show in conditional compilation for LWIP_ROUTE
components/dfs/Kconfig Updated defaults for procfs, tmpfs, and mqueue under RT_USING_SMART

return NULL;
}

#if LWIP_ROUTE
Copy link

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a comment explaining that the route_show function is conditionally compiled based on the LWIP_ROUTE flag to clarify its dependency for future maintainers.

Copilot uses AI. Check for mistakes.
config RT_USING_DFS_PROCFS
bool "Enable proc file system"
default n
default y
Copy link

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Update for RT_USING_DFS_PROCFS default is appropriate; however, add an inline comment explaining that enabling procfs by default under smart is intentional to improve maintainability.

Copilot uses AI. Check for mistakes.

config RT_USING_DFS_TMPFS
bool "Enable TMP file system"
default y if RT_USING_SMART
Copy link

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] For clarity, consider including a comment that details why TMPFS (and similarly MQUEUE on line 213) is conditionally enabled when using smart configurations.

Copilot uses AI. Check for mistakes.
@Rbb666 Rbb666 merged commit d1628a1 into RT-Thread:master May 20, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants