Skip to content

Conversation

@Maihuanyi
Copy link
Contributor

@Maihuanyi Maihuanyi commented May 21, 2025

拉取/合并请求描述:(PR description)

[

  • 描述:为了实现片上flash做文件系统,在使用fal组件时发现驱动缺少drv_flash的代码,所以便编写了drv_flash的代码配合fal使用;

  • BSP:
    [bsp][wch][risc-v][yd-ch32v307vct6]/[ch32v307v-r1]:增加drv_flash的代码;已在开发版验证drv_flash的代码;

  • .congfig需要增加CONFIG_BSP_USING_ON_CHIP_FLASH=y
    注意:ch32v307的flash可以调整大小的,要和链接文件及board.h的对应;
    ]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP BSP: WCH BSP related with WCH labels May 21, 2025
@supperthomas
Copy link
Member

# CONFIG_PKG_USING_MFBD is not set
# CONFIG_PKG_USING_SLCAN2RTT is not set
# CONFIG_PKG_USING_SOEM is not set
# CONFIG_PKG_USING_QPARAM is not set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个和rtconfig.h不需要每次提交,

Copy link
Contributor Author

@Maihuanyi Maihuanyi May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下次不提交了这两个文件了

@Maihuanyi Maihuanyi closed this May 23, 2025
                   2. fix programs a word at chip flash timeout.
                   3. priority use of fast mode.
@Maihuanyi Maihuanyi reopened this May 23, 2025
@supperthomas supperthomas merged commit 5153f38 into RT-Thread:master May 23, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: WCH BSP related with WCH BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants