Skip to content

Conversation

@htl5241
Copy link
Contributor

@htl5241 htl5241 commented May 25, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added Kernel PR has src relate code tools labels May 25, 2025
@htl5241
Copy link
Contributor Author

htl5241 commented May 25, 2025

已经全部做过测试

@htl5241
Copy link
Contributor Author

htl5241 commented May 26, 2025

人那,请快一点拉入主线,我后面还有个pr,在 100mhz arm-m4 内核性能提升15%左右,而且解决我说任务丢失的问题。


thread->error = -RT_EINTR;

/* notify a pending rescheduling */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为什么要取消一次schedule?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为什么要取消一次schedule?

void rt_exit_critical(void)
{
rt_base_t level;

/* disable interrupt */
level = rt_hw_interrupt_disable();

rt_scheduler_lock_nest--;
if (rt_scheduler_lock_nest <= 0)
{
rt_scheduler_lock_nest = 0;
/* enable interrupt */
rt_hw_interrupt_enable(level);

if (rt_current_thread)
{
/* if scheduler is started, do a schedule /
rt_schedule();
}
}
else
{
/
enable interrupt */
rt_hw_interrupt_enable(level);
}

}
RTM_EXPORT(rt_exit_critical);
退出危险区 会自动调度一次


current_tick = rt_tick_get();

rt_list_init(&list);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移除上面的赋值后,可以把rt_list_init放到irqsave的前面,这样确保关闭irq的时间更短。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移除上面的赋值后,可以把rt_list_init放到irqsave的前面,这样确保关闭irq的时间更短。

这个是移除的 冗余代码

Copy link
Member

@BernardXiong BernardXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个PR标题取得也很魔幻,开始以为是cmake的问题;然后又是tick相关的。以及这些一些并不是问题,用修复一词,显得这些都是bug。

@htl5241 htl5241 changed the title cmake.py修复 , 各种事件时钟溢出修复。 cmake.py修复 , 各种事件时钟溢出优化。 May 27, 2025
@htl5241
Copy link
Contributor Author

htl5241 commented May 27, 2025

这个PR标题取得也很魔幻,开始以为是cmake的问题;然后又是tick相关的。以及这些一些并不是问题,用修复一词,显得这些都是bug。

t_tick_t rt_tick_get_delta(rt_tick_t base)
{
rt_tick_t tnow = rt_tick_get();
if (tnow >= base)
return tnow - base;
return RT_TICK_MAX - base + tnow + 1;
}
之前没溢出前 肯定没事,系统跑着早晚溢出。 这个函数 ,可以正确处理溢出的问题。

@htl5241 htl5241 closed this by deleting the head repository May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kernel PR has src relate code tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants