-
Notifications
You must be signed in to change notification settings - Fork 5.3k
cmake.py修复 , 各种事件时钟溢出优化。 #10324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake.py修复 , 各种事件时钟溢出优化。 #10324
Conversation
|
已经全部做过测试 |
|
人那,请快一点拉入主线,我后面还有个pr,在 100mhz arm-m4 内核性能提升15%左右,而且解决我说任务丢失的问题。 |
|
|
||
| thread->error = -RT_EINTR; | ||
|
|
||
| /* notify a pending rescheduling */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为什么要取消一次schedule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为什么要取消一次schedule?
void rt_exit_critical(void)
{
rt_base_t level;
/* disable interrupt */
level = rt_hw_interrupt_disable();
rt_scheduler_lock_nest--;
if (rt_scheduler_lock_nest <= 0)
{
rt_scheduler_lock_nest = 0;
/* enable interrupt */
rt_hw_interrupt_enable(level);
if (rt_current_thread)
{
/* if scheduler is started, do a schedule /
rt_schedule();
}
}
else
{
/ enable interrupt */
rt_hw_interrupt_enable(level);
}
}
RTM_EXPORT(rt_exit_critical);
退出危险区 会自动调度一次
|
|
||
| current_tick = rt_tick_get(); | ||
|
|
||
| rt_list_init(&list); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
移除上面的赋值后,可以把rt_list_init放到irqsave的前面,这样确保关闭irq的时间更短。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
移除上面的赋值后,可以把rt_list_init放到irqsave的前面,这样确保关闭irq的时间更短。
这个是移除的 冗余代码
BernardXiong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个PR标题取得也很魔幻,开始以为是cmake的问题;然后又是tick相关的。以及这些一些并不是问题,用修复一词,显得这些都是bug。
|
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up