[bsp]stm32f103-keysking 驱动：uart、pwm、pulse encoder #10330

QianJiu05 · 2025-05-27T16:11:33Z

拉取/合并请求描述：(PR description)

[

stm32f103-keysking-learning

为什么提交这份PR (why to submit this PR)

为stm32f103-keysking-learning的bsp添加uart、pwm、pulse encoder驱动

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

BSP:bsp/stm32/stm32f103-keysking-learning

.config:

action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

action编译报错： board/CubeMX_Config/Src/stm32f1xx_hal_msp.c:23:10: fatal error: main.h: No such file or directory 23 | #include "main.h" | ^~~~~~~~

Rbb666 · 2025-05-28T02:52:24Z

bsp/stm32/stm32f103-keysking-learning/.config

 # CONFIG_RT_USING_RANDOM is not set
-# CONFIG_RT_USING_PWM is not set
-# CONFIG_RT_USING_PULSE_ENCODER is not set
+CONFIG_RT_USING_PWM=y


这两个驱动默认不用打开吧，保持关闭就好

Rbb666 · 2025-05-28T02:53:42Z

作者是否愿意负责此BSP的看护工作，可以的话欢迎添加到MAINTAINERS中：https://github.com/RT-Thread/rt-thread/blob/master/MAINTAINERS

QianJiu05 · 2025-05-28T04:34:37Z

作者是否愿意负责此BSP的看护工作，可以的话欢迎添加到MAINTAINERS中：https://github.com/RT-Thread/rt-thread/blob/master/MAINTAINERS

请问看护需要做什么呢？跟进新功能吗

Rbb666 · 2025-05-28T05:51:24Z

作者是否愿意负责此BSP的看护工作，可以的话欢迎添加到MAINTAINERS中：https://github.com/RT-Thread/rt-thread/blob/master/MAINTAINERS

请问看护需要做什么呢？跟进新功能吗

可详见文章中的审核团成员职责章节：https://mp.weixin.qq.com/s/h3WFcTu5Y61qBxFGS8uaxQ

supperthomas · 2025-05-28T06:08:30Z

bsp/stm32/stm32f103-keysking-learning/.config

-# CONFIG_RT_USING_PWM is not set
-# CONFIG_RT_USING_PULSE_ENCODER is not set
+CONFIG_RT_USING_PWM=y
+CONFIG_RT_USING_PULSE_ENCODER=y


这里保留最小配置即可，其他配置可以用yml来加ci检查和使用。
rtconfig.h和.config没有特殊情况，不需要修改和提交

QianJiu05 · 2025-05-28T08:28:28Z

作者是否愿意负责此BSP的看护工作，可以的话欢迎添加到MAINTAINERS中：https://github.com/RT-Thread/rt-thread/blob/master/MAINTAINERS

请问是直接加还是通过后面那个链接的二维码报名呀？

Copilot

Pull Request Overview

This PR adds support for new peripheral drivers—UART, PWM, and pulse encoder—for the stm32f103-keysking-learning board.

Enables PWM and pulse encoder functionality in rtconfig.h.
Updates project and board configuration files (Kconfig, .uvprojx, .ewp, CubeMX_Config files) to include new source files and peripheral mappings.
Revises the README and CI attachment configurations to document and test the new features.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
rtconfig.h	Adds RT_USING_PWM and RT_USING_PULSE_ENCODER macros.
project.uvprojx & project.ewp	Updates project file definitions and include paths for added drivers.
board/Kconfig	Introduces new configuration options for servo, PWM, and pulse encoder.
CubeMX_Config (stm32f1xx_hal_msp.c, .ioc, etc.)	Adjusts HAL initialization and pin mappings for new peripherals.
README.md	Updates board peripheral support information.
.config	Adjusts BSP configuration settings for new drivers.
.ci/attachconfig/ci.attachconfig.yml	Adds attach config entries for servo and pulse encoder devices.

Copilot · 2025-05-28T08:42:39Z

bsp/stm32/stm32f103-keysking-learning/.config

+# CONFIG_BSP_USING_UART3 is not set
+# CONFIG_BSP_USING_PWM is not set
+# CONFIG_BSP_USING_PULSE_ENCODER is not set


The .config file still shows BSP_USING_UART3, BSP_USING_PWM, and BSP_USING_PULSE_ENCODER as disabled, which conflicts with their usage in rtconfig.h and the CI attachment. Please ensure that the configuration defaults are consistent across the files.

Suggested change

# CONFIG_BSP_USING_UART3 is not set

# CONFIG_BSP_USING_PWM is not set

# CONFIG_BSP_USING_PULSE_ENCODER is not set

CONFIG_BSP_USING_UART3=y

CONFIG_BSP_USING_PWM=y

CONFIG_BSP_USING_PULSE_ENCODER=y

Copilot · 2025-05-28T08:42:40Z

bsp/stm32/stm32f103-keysking-learning/board/Kconfig

        select BSP_USING_UART
        select BSP_USING_UART2
        default y
+    config BSP_USING_SERVO


The servo configuration defaults to disabled (default n) in Kconfig, yet the CI attach configuration forces CONFIG_BSP_USING_SERVO to y. Please review and align the defaults across configurations.

supperthomas · 2025-05-28T10:15:53Z

.config 删除，不用提交。

QianJiu05 · 2025-05-28T14:51:51Z

.config 删除，不用提交。

你好删除了好像过不了ci是没问题的吗😭

supperthomas · 2025-05-29T01:49:44Z

.config 删除，不用提交。

你好删除了好像过不了ci是没问题的吗😭

不是说让你删除，是让你不要提交，你恢复到上一个版本即可，你看你的PR里面不要有.config的修改。

Rbb666 · 2025-05-29T01:51:14Z

.config 删除，不用提交。

你好删除了好像过不了ci是没问题的吗😭

不用提交.config就行啦

supperthomas · 2025-05-29T01:58:03Z

  <<: *scons
  kconfig:
    CONFIG_RT_USING_NANO=y

这个配置名称呢？

supperthomas · 2025-05-29T01:58:18Z

bsp/stm32/stm32f103-keysking-learning/.ci/attachconfig/ci.attachconfig.yml

 system.use_nano:
  <<: *scons
  kconfig:
    CONFIG_RT_USING_NANO=y


配置名呢？

这个完整内容是：
system.use_nano:
<<: *scons
kconfig:
CONFIG_RT_USING_NANO=y

是开启use_nano的
效果如下：

nano: scons_arg: - '--strict' kconfig: - CONFIG_RT_USING_NANO=y

本地有试过：
scons --attach=system.use_nano 生效吗？

本地试虽然显示成功但是其实没成功，我之前看success了以为没问题了。请问是只有devices开头的命令才会生效吗，我刚才试了一下定义其他类也是失败的

用这个吧,或者不是必须测的就去掉吧。其他bsp已经测过nano了

nano: scons_arg: - '--strict' kconfig: - CONFIG_RT_USING_NANO=y

supperthomas · 2025-05-29T02:05:03Z

CI显示你这个nano配置有问题。

supperthomas · 2025-05-29T02:33:29Z

bsp/stm32/stm32f103-keysking-learning/.ci/attachconfig/ci.attachconfig.yml

 system.use_nano:
  <<: *scons
  kconfig:
    CONFIG_RT_USING_NANO=y


用这个吧,或者不是必须测的就去掉吧。其他bsp已经测过nano了

nano: scons_arg: - '--strict' kconfig: - CONFIG_RT_USING_NANO=y

supperthomas · 2025-05-29T02:34:24Z

yml只需要保留你自己认为该bsp常用的配置即可。

supperthomas · 2025-05-29T02:38:16Z

bsp/stm32/stm32f103-keysking-learning/.ci/attachconfig/ci.attachconfig.yml

 system.use_nano:
  <<: *scons
  kconfig:
    CONFIG_RT_USING_NANO=y


你这个缺个-号。

QianJiu05 · 2025-05-29T02:39:56Z

yml只需要保留你自己认为该bsp常用的配置即可。

明白了🌹

QianJiu05 added 4 commits May 26, 2025 12:34

[bsp]stm32f103keysking:add uart3

3b23b29

[bsp]stm32f103-keysking pwm驱动

0a03782

[bsp]stm32f103-keysking pulse encoder设备驱动

825140b

[bsp]前三个commit的mdk5和iar工程

d57c201

github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels May 27, 2025

[bsp]修复action报错：原文件多include了main.h，已删除并重新生成工程

a3b17cc

action编译报错： board/CubeMX_Config/Src/stm32f1xx_hal_msp.c:23:10: fatal error: main.h: No such file or directory 23 | #include "main.h" | ^~~~~~~~

Rbb666 reviewed May 28, 2025

View reviewed changes

修改.config关闭pwm

f1c7de0

supperthomas requested changes May 28, 2025

View reviewed changes

[bsp]stm32f103-keysking 修改config，只开启finsh和gpio

f266d18

supperthomas requested a review from Copilot May 28, 2025 08:41

Copilot AI reviewed May 28, 2025

View reviewed changes

[bsp]关闭config的PWM和Encoder（通过select开启的关闭不会默认取消）

cc9e18c

删除.config文件

3bcf6d4

.config 未修改版本

613206c

supperthomas approved these changes May 29, 2025

View reviewed changes

supperthomas requested changes May 29, 2025

View reviewed changes

修改ci yml

ad3b580

supperthomas requested changes May 29, 2025

View reviewed changes

supperthomas approved these changes May 29, 2025

View reviewed changes

supperthomas added the +1 Agree +1 label May 29, 2025

supperthomas merged commit 2cf2161 into RT-Thread:master May 29, 2025
35 checks passed

Rbb666 pushed a commit that referenced this pull request May 30, 2025

[bsp]stm32f103-keysking 驱动：uart、pwm、pulse encoder (#10330)

425ac77

[bsp]stm32f103-keysking 驱动：uart、pwm、pulse encoder #10330

[bsp]stm32f103-keysking 驱动：uart、pwm、pulse encoder #10330

Uh oh!

Conversation

QianJiu05 commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rbb666 commented May 28, 2025

Uh oh!

QianJiu05 commented May 28, 2025

Uh oh!

Rbb666 commented May 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QianJiu05 commented May 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2025

Choose a reason for hiding this comment

Uh oh!

supperthomas commented May 28, 2025

Uh oh!

QianJiu05 commented May 28, 2025

Uh oh!

supperthomas commented May 29, 2025

Uh oh!

Rbb666 commented May 29, 2025

Uh oh!

supperthomas commented May 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QianJiu05 May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

supperthomas commented May 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

supperthomas commented May 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QianJiu05 commented May 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

QianJiu05 commented May 27, 2025 •

edited

Loading

QianJiu05 May 29, 2025 •

edited

Loading