玄铁全系列RISC-V内核支持（E系列/R系列/C系列） #10343

Yaochenger · 2025-05-29T10:44:48Z

拉取/合并请求描述：(PR description)

[

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

Rbb666 · 2025-05-30T01:34:19Z

@Yaochenger 请先修复CI的报错，然后相关的BSP可以添加到CI看护里面😊

github-actions · 2025-05-30T02:19:22Z

📌 Code Review Assignment

🏷️ Tag: workflow

Path: .github
Reviewers: supperthomas Rbb666 kurisaW

Changed Files (Click to expand)

.github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-06-10 01:50 UTC)

⌛ Rbb666 Pending Review
⌛ kurisaW Pending Review
⌛ supperthomas Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Copilot

Pull Request Overview

This PR aims to add comprehensive support for the XuanTie RISC-V cores across the E, R, and C series by removing obsolete/system-specific implementations and updating build configurations.

Legacy system initialization, startup, and trap handling files for various architectures (e.g., c907fd, c907fd-rv32, c906fdv, etc.) have been removed.
The linker script’s minimum heap size has been increased significantly, and the BSP compile configuration JSON has been updated to include additional board configurations.

Reviewed Changes

Copilot reviewed 314 out of 314 changed files in this pull request and generated no comments.

File	Description
bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/src/arch/*	Removal of legacy system, startup, and trap handling code for various chip variants to consolidate or replace with new implementations
bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/gcc_flash_xiaohui.ld	Increased __min_heap_size value to support new platform memory requirements
.github/ALL_BSP_COMPILE.json	Updated BSP sub-configurations to include new board variants

Comments suppressed due to low confidence (2)

bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/src/arch/c907fd/system.c:1

Multiple system initialization and trap handling files have been removed across various architectures; please confirm that all dependent modules have been updated to use the new consolidated support for RISC-V cores to avoid unresolved references.

/* entire file removal */

bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/gcc_flash_xiaohui.ld:24

The minimum heap size has been increased from 0x200 to 0x20000; please verify that this new value meets the memory requirements of the updated configurations and does not introduce unintended memory overhead.

__min_heap_size = 0x20000;

Rbb666 · 2025-05-30T05:46:57Z

bsp/xuantie/smartl/e902/SConscript

+objs = []
+list = os.listdir(cwd)
+
+for d in list:


这部分对于当前目录是多余的代码，可以删除

Rbb666 · 2025-05-30T05:51:14Z

bsp/xuantie/xiaohui/c906/board/Kconfig

+
+config SOC_XUANTIE
+    bool
+    select SOC_XUANTIE_SERIES_E906


这个命名和bsp所属架构不统一

Rbb666 · 2025-06-03T09:40:27Z

bsp/xuantie/xiaohui/r920/figures/1.env.png

Rbb666 · 2025-06-03T09:46:54Z

bsp/xuantie/xiaohui/r910/figures/1.env.png

图片和目录都没对上，需要修改

Rbb666 · 2025-06-03T09:47:15Z

bsp/xuantie/xiaohui/r910/board/Kconfig

+
+config SOC_XUANTIE
+    bool
+    select SOC_XUANTIE_SERIES_E906


名称要改下

Rbb666 · 2025-06-03T09:56:57Z

bsp/xuantie/xiaohui/r908/board/Kconfig

+
+config SOC_XUANTIE
+    bool
+    select SOC_XUANTIE_SERIES_E906


BSP下面的Kconfig都需要检查下

已修正 a492dd9

ann-yanan · 2025-06-09T05:27:12Z

bsp/xuantie/smartl/e902/Kconfig

E902在smartl平台上运行

已修正 458c6f6

Yaochenger added 3 commits May 29, 2025 18:36

[xuantie] 精简libraries

1fafa3f

[xuantie] 添加E907 BSP

dcd17ed

[xuantie] 添加E902 BSP

8903606

github-actions bot added the BSP label May 29, 2025

Yaochenger force-pushed the XUANTIE branch from 4918254 to c2ae568 Compare May 30, 2025 01:45

[xuantie] 添加玄铁R,C全系列RTOS支持

da6b9fc

Yaochenger force-pushed the XUANTIE branch from c2ae568 to da6b9fc Compare May 30, 2025 02:05

Yaochenger requested a review from supperthomas as a code owner May 30, 2025 02:19

github-actions bot added the action github action yml imporve label May 30, 2025

添加BSP CI看护

d317bc5

Yaochenger force-pushed the XUANTIE branch from c5b9391 to d317bc5 Compare May 30, 2025 02:31

supperthomas requested a review from Copilot June 2, 2025 19:22

Copilot AI reviewed Jun 2, 2025

View reviewed changes

修正部分定义

045dd73

Yaochenger force-pushed the XUANTIE branch from 5f74347 to 045dd73 Compare June 3, 2025 09:19

Rbb666 requested changes Jun 3, 2025

View reviewed changes

修正board/Kconfig中的错误命名

a492dd9

Rbb666 approved these changes Jun 9, 2025

View reviewed changes

ann-yanan reviewed Jun 9, 2025

View reviewed changes

修正SMARTL平台BSP的Kconfig

458c6f6

Yaochenger requested a review from ann-yanan June 10, 2025 01:51

Rbb666 added the Arch: RISC-V BSP related with risc-v label Jun 10, 2025

Rbb666 merged commit cec2dbd into RT-Thread:master Jun 10, 2025
59 checks passed

Yaochenger deleted the XUANTIE branch July 3, 2025 06:07

玄铁全系列RISC-V内核支持（E系列/R系列/C系列） #10343

玄铁全系列RISC-V内核支持（E系列/R系列/C系列） #10343

Uh oh!

Conversation

Yaochenger commented May 29, 2025

拉取/合并请求描述：(PR description)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

Rbb666 commented May 30, 2025

Uh oh!

github-actions bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: workflow

📊 Current Review Status (Last Updated: 2025-06-10 01:50 UTC)

📝 Review Instructions

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented May 30, 2025 •

edited

Loading