-
Notifications
You must be signed in to change notification settings - Fork 5.3k
bsp: artpi2: init project. #10364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsp: artpi2: init project. #10364
Conversation
Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>
|
emm, I don't know whether rtthread official had plans to release the artpi2 bsp. Just push it here. |
Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>
|
📄 bsp/stm32/stm32h7r7-artpi2/figures/board_large.png — [A] 📄 bsp/stm32/stm32h7r7-artpi2/figures/create_proj.png — [A] 📄 bsp/stm32/stm32h7r7-artpi2/figures/qq_group.png — [A] 📄 bsp/stm32/stm32h7r7-artpi2/figures/sdk_manager.png — [A] 图片压缩一下。清理一下project下面的多余的文件 |
bsp/stm32/libraries/Kconfig
Outdated
|
|
||
| config SOC_SERIES_STM32H7RS | ||
| bool | ||
| default y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为啥要加y?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂当时调的时候加的,忘记删了
Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>
Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR initializes the ART-Pi2 BSP project for the STM32H7R7 microcontroller, integrating CubeMX-generated configuration, linker setup, core system code, and RT-Thread application scaffolding.
- Added CubeMX CMake configuration and static library targets for HAL drivers
- Introduced linker script and system startup files (system init, sysmem, syscalls, interrupts)
- Created RT-Thread application example with SCons build scripts and updated documentation
Reviewed Changes
Copilot reviewed 49 out of 49 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/mx-generated.cmake | CubeMX-generated CMake build configuration |
| bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/STM32H7R7XX.ld | Linker script for FLASH and RAM layout |
| bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Src/system_stm32h7rsxx.c | CMSIS system init and clock configuration |
| bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Src/sysmem.c | _sbrk heap allocation implementation |
| bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Src/syscalls.c | Minimal newlib system call stubs |
| bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Src/stm32h7rsxx_it.c | Interrupt service routines |
| bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Inc/stm32h7rsxx_it.h | Interrupt handler prototypes |
| bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/Core/Inc/main.h | Application-wide defines (LED pin) and prototypes |
| bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/CMakePresets.json | CMake presets for build configurations |
| bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/.mxproject | STM32CubeMX project metadata |
| bsp/stm32/stm32h7r7-artpi2/board/.ignore_format.yml | Paths excluded from code-format checks |
| bsp/stm32/stm32h7r7-artpi2/applications/main.c | RT-Thread LED blink example and vector relocation |
| bsp/stm32/stm32h7r7-artpi2/applications/SConscript | SCons script for application build grouping |
| bsp/stm32/stm32h7r7-artpi2/SConstruct | Top-level SCons build script for BSP |
| bsp/stm32/stm32h7r7-artpi2/SConscript | Module SCons script for driver compilation |
| bsp/stm32/stm32h7r7-artpi2/README_en.md | English documentation and usage instructions |
| bsp/stm32/stm32h7r7-artpi2/README.md | Chinese documentation |
| bsp/stm32/stm32h7r7-artpi2/Kconfig | RT-Thread Kconfig integration |
| bsp/stm32/stm32h7r7-artpi2/EventRecorderStub.scvd | Event recorder stub component metadata |
| bsp/stm32/stm32h7r7-artpi2/.gitignore | File patterns to ignore in VCS |
Comments suppressed due to low confidence (3)
bsp/stm32/stm32h7r7-artpi2/board/CubeMX_Config/Appli/STM32H7R7XX.ld:10
- Header comment reports incorrect memory sizes; update to reflect actual FLASH (65536K) and RAM (455K + 64K DTCM).
** 67108864Kbytes FLASH and 0Kbytes RAM
bsp/stm32/stm32h7r7-artpi2/SConscript:11
- The define 'STM32H7S7xx' appears to be a typo; it should likely be 'STM32H7R7xx' to match the MCU series.
env.Append(CPPDEFINES = ['STM32H7S7xx'])
bsp/stm32/stm32h7r7-artpi2/README_en.md:38
- Document references 'RealThread_STMH7R-ART-Pi.yaml', but the repository file is named 'RealThread_STM32H7R-ART-Pi2.yaml'; update for consistency.
- **RealThread_STMH7R-ART-Pi.yaml**: Describes the hardware information of ART-Pi.
| ${CMAKE_SOURCE_DIR}/../Drivers/STM32H7RSxx_HAL_Driver/Src/stm32h7rsxx_ll_usb.c | ||
| ) | ||
|
|
||
| # Drivers Midllewares |
Copilot
AI
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in comment: replace "Midllewares" with "Middlewares".
| # Drivers Midllewares | |
| # Drivers Middlewares |
| list = os.listdir(cwd) | ||
|
|
||
| env.Append(CPPDEFINES = ['STM32H7S7xx']) | ||
|
|
||
| for d in list: |
Copilot
AI
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Variable 'list' shadows the built-in Python type; consider renaming to avoid confusion (e.g., 'entries').
| list = os.listdir(cwd) | |
| env.Append(CPPDEFINES = ['STM32H7S7xx']) | |
| for d in list: | |
| entries = os.listdir(cwd) | |
| env.Append(CPPDEFINES = ['STM32H7S7xx']) | |
| for d in entries: |
supperthomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请添加自己需要的文件,编译不到的多余文件,自动生成的文件,都删除
| @@ -0,0 +1,60 @@ | |||
| { | |||
| "version": 3, | |||
| "configurePresets": [ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余
|
|
||
| <component_viewer schemaVersion="0.1" xmlns:xs="http://www.w3.org/2001/XMLSchema-instance" xs:noNamespaceSchemaLocation="Component_Viewer.xsd"> | ||
|
|
||
| <component name="EventRecorderStub" version="1.0.0"/> <!--name and version of the component--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余
|
|
||
| /* USER CODE END SysTick_IRQn 0 */ | ||
| HAL_IncTick(); | ||
| /* USER CODE BEGIN SysTick_IRQn 1 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余
| */ | ||
|
|
||
| /* Includes */ | ||
| #include <errno.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余
| * constant and the selected clock source: | ||
| * | ||
| * - If SYSCLK source is HSI, SystemCoreClock will contain the HSI_VALUE(*) | ||
| * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余
| ** Set memory bank area and size if external memory is used. | ||
| ** | ||
| ** Target : STMicroelectronics STM32 | ||
| ** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余
|
|
||
| . = ALIGN(4); | ||
| _ebss = .; /* define a global symbol at bss end */ | ||
| __bss_end__ = _ebss; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余
|
|
||
| set(CMAKE_EXECUTABLE_SUFFIX_ASM ".elf") | ||
| set(CMAKE_EXECUTABLE_SUFFIX_C ".elf") | ||
| set(CMAKE_EXECUTABLE_SUFFIX_CXX ".elf") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余
| message(" Build context: " Appli) | ||
| ExternalProject_Add(CubeMX_Config_Appli | ||
| BINARY_DIR ${CMAKE_SOURCE_DIR}/Appli/build | ||
| SOURCE_DIR ${PROJECT_SOURCE_DIR}/Appli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余
Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>
📌 Code Review Assignment🏷️ Tag: workflowPath: Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-06-08 01:11 UTC)
📝 Review Instructions
|
Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>
| /** | ||
| ****************************************************************************** | ||
| * @file stm32h7rsxx_it.h | ||
| * @brief This file contains the headers of the interrupt handlers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请删除
| /* Private includes ----------------------------------------------------------*/ | ||
| /* USER CODE BEGIN Includes */ | ||
|
|
||
| /* USER CODE END Includes */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
删除
| @@ -0,0 +1,1097 @@ | |||
| /* USER CODE BEGIN Header */ | |||
| /** | |||
| ****************************************************************************** | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
删除
| * @brief STM32H7R7xx Devices vector table for GCC toolchain. | ||
| * This module performs: | ||
| * - Set the initial SP | ||
| * - Set the initial PC == Reset_Handler, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
删除
Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>
.github/ALL_BSP_COMPILE.json
Outdated
| "stm32/stm32h750-weact-ministm32h7xx", | ||
| "stm32/stm32h750-fk750m1-vbt6", | ||
| "stm32/stm32h7s7-st-disco", | ||
| "stm32/stm32h7r7-artpi2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请检查下这块的缩进
|
|
||
| POST_ACTION = 'fromelf --bin $TARGET --output rtthread.bin \nfromelf -z $TARGET' | ||
|
|
||
| elif PLATFORM == 'iccarm': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
此工程如果没有验证的工具链比如(IAR)的,可以删除,只保留验证过的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>
Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>
Signed-off-by: stranding <45762837+StrandingNeko@users.noreply.github.com>

拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up