Skip to content

Conversation

@htl5241
Copy link
Contributor

@htl5241 htl5241 commented Jun 5, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the Kernel PR has src relate code label Jun 5, 2025
@htl5241
Copy link
Contributor Author

htl5241 commented Jun 5, 2025

这个patch 修复的是,当tick溢出时可以正确计算。

@htl5241
Copy link
Contributor Author

htl5241 commented Jun 5, 2025

@Rbb666 review 一下

@htl5241
Copy link
Contributor Author

htl5241 commented Jun 5, 2025

当系统长时间不关机,tick溢出,所在的事件就会出问题。

@supperthomas supperthomas requested a review from Copilot June 5, 2025 06:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes redundant tick calculations and addresses timer overflow by adopting safer delta-based comparisons across several subsystems.

  • Replaced direct tick arithmetic with overflow-safe logic in timer.c
  • Updated rt_thread_delay_until in thread.c to use rt_tick_get_delta and refined overflow handling
  • Standardized timeout adjustments in mempool.c and ipc.c using rt_tick_get_delta

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/timer.c Removed redundant current_tick, changed overflow check to raw subtraction
src/thread.c Swapped manual tick diff with rt_tick_get_delta, refactored delay-until logic
src/mempool.c Replaced rt_tick_get() subtraction with rt_tick_get_delta
src/ipc.c Renamed tick_delta to tick_stamp and applied rt_tick_get_delta for all timeout recalculations


ret = _timer_list_next_timeout(_soft_timer_list, &next_timeout);
if ((ret == RT_EOK) && (next_timeout <= rt_tick_get()))
if ((ret == RT_EOK) && ((rt_tick_get() - next_timeout) < RT_TICK_MAX / 2))
Copy link

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider replacing the raw subtraction with the overflow-safe helper rt_tick_get_delta(next_timeout) for consistency and clarity.

Suggested change
if ((ret == RT_EOK) && ((rt_tick_get() - next_timeout) < RT_TICK_MAX / 2))
if ((ret == RT_EOK) && (rt_tick_get_delta(next_timeout) < RT_TICK_MAX / 2))

Copilot uses AI. Check for mistakes.
src/thread.c Outdated
{
rt_tick_t left_tick;
rt_tick_t target_tick;
target_tick = *tick + inc_tick;
Copy link

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After computing left_tick, the code never updates *tick to target_tick, so subsequent calls may use an outdated baseline. Consider adding *tick = target_tick; before suspending the thread.

Copilot uses AI. Check for mistakes.
@htl5241 htl5241 closed this Jun 5, 2025
@htl5241 htl5241 reopened this Jun 5, 2025
@htl5241 htl5241 closed this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kernel PR has src relate code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant