Skip to content

Conversation

@unicornx
Copy link
Contributor

utest 原代码中对 case 名字的匹配有问题,因为采用 memcmp 按照 len 的字节匹配,如果输入的 case name 和存在的 case name 存在包含关系,譬如实际 case 名字是 ”gpip_irq“, 输入 utest_run gpio 也会匹配成功, 但这不是期望的结果。

修改精确匹配的逻辑,直接采用 strcmp。

同时保留原先通配的逻辑,即 utest_run gpio* 可以同时匹配 ”gpio“ 和 ”gpio_irq“。

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

There is a problem with the matching of case names
in the original code. Due to original code use memcmp
with len, if the input case name and the existing
case name have an inclusion relationship, for example,
if the actual case name is "gpip_irq", and run
`utest_run gpio` will also match successfully, but it's
not expected.

Modify the logic of exact matching and use strcmp instead.
Keep the original wildcard logic, that is,
`utest_run gpio*` can match both "gpio_irq" and "gpio".

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
@unicornx unicornx requested a review from Rbb666 June 10, 2025 10:29
@unicornx
Copy link
Contributor Author

@Rbb666 静态检查的报错看上去和我的修改没有关系啊,请帮忙看一下呢。

@Rbb666
Copy link
Member

Rbb666 commented Jun 10, 2025

@Rbb666 静态检查的报错看上去和我的修改没有关系啊,请帮忙看一下呢。

因为修改了utest.c 触发了ci检查,此报错可以忽略

@Rbb666 Rbb666 merged commit 01ca391 into RT-Thread:master Jun 10, 2025
57 of 58 checks passed
@unicornx unicornx deleted the dev-utest-name branch June 25, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants