Skip to content

Conversation

@wdfk-prog
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions
Copy link

github-actions bot commented Jun 10, 2025

📌 Code Review Assignment

🏷️ Tag: maintainers

Path: MAINTAINERS
Reviewers: Rbb666 kurisaW

Changed Files (Click to expand)
  • MAINTAINERS

📊 Current Review Status (Last Updated: 2025-06-13 05:47 UTC)

  • Rbb666 Pending Review
  • kurisaW Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Rbb666
Copy link
Member

Rbb666 commented Jun 12, 2025

刚刚合并了一个PR,导致冲突了,麻烦作者变基下master

@wdfk-prog
Copy link
Contributor Author

刚刚合并了一个PR,导致冲突了,麻烦作者变基下master

  • 已修改.
  • 但是看file changed怪怪的,另一个人的patch怎么变成我提的了

@lianux-mm
Copy link
Contributor

刷新下就好了,现在没问题了应该是

@Rbb666
Copy link
Member

Rbb666 commented Jun 13, 2025

刚刚合并了一个PR,导致冲突了,麻烦作者变基下master

  • 已修改.
  • 但是看file changed怪怪的,另一个人的patch怎么变成我提的了

10383 pr的内容不用引入进来,添加自己那部分即可

@kurisaW
Copy link
Member

kurisaW commented Jun 13, 2025

@wdfk-prog 麻烦驱动框架相关修改为driver_xxx前缀,另外顺序请按字母排序

@wdfk-prog
Copy link
Contributor Author

driver

@wdfk-prog 麻烦驱动框架相关修改为driver_xxx前缀,另外顺序请按字母排序

已修改

@Rbb666
Copy link
Member

Rbb666 commented Jun 13, 2025

lgtm

1 similar comment
@kurisaW
Copy link
Member

kurisaW commented Jun 13, 2025

lgtm

@Rbb666 Rbb666 merged commit b23d87b into RT-Thread:master Jun 13, 2025
59 checks passed
@wdfk-prog wdfk-prog deleted the MAINTAINERS branch June 17, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants