Skip to content

Conversation

@godmial
Copy link
Contributor

@godmial godmial commented Jun 19, 2025

拉取/合并请求描述:(PR description)

1.更改armcc编译器为armclang 2.修改sconstruct代码为更加通用的方式 3.删除SPI flash 在使用DFS时自动挂载逻辑

修改之后正常编译,运行
image

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [*] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [*] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [*] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [*] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [*] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [*] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [*] 代码是高质量的 Code in this PR is of high quality
  • [*] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • [*] 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP BSP: GD32 BSP related with GD32 labels Jun 19, 2025
@github-actions
Copy link

📌 Code Review Assignment

🏷️ Tag: bsp_gd32470z-lckfb

Path: bsp/gd32/arm/gd32470z-lckfb
Reviewers: @godmial

Changed Files (Click to expand)
  • bsp/gd32/arm/gd32470z-lckfb/SConstruct
  • bsp/gd32/arm/gd32470z-lckfb/rtconfig.py

📊 Current Review Status (Last Updated: 2025-06-19 08:07 UTC)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@kurisaW kurisaW requested review from kurisaW and removed request for kurisaW June 20, 2025 01:31
@Rbb666 Rbb666 merged commit 593ac8d into RT-Thread:master Jun 22, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: GD32 BSP related with GD32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants