Skip to content

[bsp]stm32 attach配置整理为yml（f0-f4、g、l系列） #10417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
supperthomas merged 8 commits into from
Jun 24, 2025
Merged

[bsp]stm32 attach配置整理为yml（f0-f4、g、l系列） #10417

supperthomas merged 8 commits into from
Jun 24, 2025

Conversation

@QianJiu05
Copy link
Contributor

@QianJiu05 QianJiu05 commented Jun 19, 2025

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels Jun 19, 2025
@github-actions
Copy link

github-actions bot commented Jun 19, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Path: bsp/stm32
Reviewers: wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/stm32f072-st-nucleo/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f072-st-nucleo/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f072-st-nucleo/.ci/attachconfig/rtduino.attach
  • bsp/stm32/stm32f091-st-nucleo/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f091-st-nucleo/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f103-100ask-mini/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f103-100ask-mini/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f103-100ask-pro/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f103-100ask-pro/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f103-atk-nano/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f103-atk-nano/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f103-atk-warshipv3/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f103-atk-warshipv3/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f103-dofly-M3S/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f103-dofly-M3S/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f103-dofly-lyc8/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f103-dofly-lyc8/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f103-fire-arbitrary/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f103-fire-arbitrary/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f103-gizwits-gokitv21/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f103-gizwits-gokitv21/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f103-hw100k-ibox/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f103-hw100k-ibox/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f103-onenet-nbiot/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f103-onenet-nbiot/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f103-yf-ufun/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f103-yf-ufun/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f103-ys-f1pro/.ci/attachconfig/ci.attachconfig.yml
  • bsp/stm32/stm32f103-ys-f1pro/.ci/attachconfig/nano.attach
  • bsp/stm32/stm32f107-uc-eval/.ci/attachconfig/ci.attachconfig.yml

📊 Current Review Status (Last Updated: 2025-06-24 12:48 UTC)

  • ⌛ wdfk-prog Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@QianJiu05
Copy link
Contributor Author

QianJiu05 commented Jun 19, 2025

奇怪，为什么elf都编译出来了却在scons -c error了...

@supperthomas
Copy link
Member

supperthomas commented Jun 20, 2025

image

主要看这几个编译的问题

@supperthomas
Copy link
Member

supperthomas commented Jun 20, 2025

stm32/stm32f723-st-disco nano
stm32/stm32l475-atk-pandora nano
stm32/stm32l475-atk-pandora rtduino.tft-espi
stm32/stm32f429-armfly-v6 nano

@supperthomas
Copy link
Member

supperthomas commented Jun 20, 2025

看了下，大部分是因为加了--strict ，有编译问题需要解决掉。加了--strict 有warning就会报错

supperthomas
supperthomas requested changes Jun 20, 2025
View reviewed changes
bsp/stm32/stm32l475-atk-pandora/.ci/attachconfig/ci.attachconfig.yml Outdated
- CONFIG_BSP_USING_SDCARD_FATFS=y
# ------ rtduino ------
rtduino.adafruit-aht10:
<<: *scons
Copy link
Member

@supperthomas supperthomas Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里都加了scons --strict ，如果有编译warning需要解决掉

@supperthomas
Copy link
Member

supperthomas commented Jun 20, 2025

如果确实需要加--strict，你可以把这几个bsp先去掉，后面再提个pr,修复好warning了，再提交。

@QianJiu05
Copy link
Contributor Author

QianJiu05 commented Jun 20, 2025

如果确实需要加--strict，你可以把这几个bsp先去掉，后面再提个pr,修复好warning了，再提交。

就是说其实可以不加strict的吗？我以为strict是每一项都要强制加的
stm32l475-atk-pandora和stm32f429-armfly-v6 这个的warning好像是原本kconfig的问题，跟yml关系不大，PKG_USING_MPU6XXX_LATEST_VERSION的warning只要访问.config就会报，我尝试修改bsp的kconfig，但作为choice类型无法聚合到BSP_USING_ICM20608项内。想不报错似乎只能独立于BSP_USING_ICM20608单独开一个config，好像不符合原意。这种情况能去掉yml的strict吗

warning: the choice symbol PKG_USING_MPU6XXX_LATEST_VERSION (defined at /home/runner/.env/packages/packages/peripherals/sensors/mpu6xxx/Kconfig:24) is selected by the following symbols, but select/imply has no effect on choice symbols

  • BSP_USING_ICM20608 (defined at board/Kconfig:177)

@supperthomas
Copy link
Member

supperthomas commented Jun 20, 2025

嗯， 一般strict 不需要加。只是目前有这个功能，

@supperthomas
Copy link
Member

supperthomas commented Jun 20, 2025

要先保证编译没问题。

@QianJiu05
Copy link
Contributor Author

QianJiu05 commented Jun 20, 2025

要先保证编译没问题。

请问action的component出问题要修吗，好像是driver的版本不对？不太敢动共用的文件，在本地编译是没问题的

@supperthomas
Copy link
Member

supperthomas commented Jun 20, 2025

要先保证编译没问题。

请问action的component出问题要修吗，好像是driver的版本不对？不太敢动共用的文件，在本地编译是没问题的

其他项目选中NANO编译可以通过，理论上应该没问题。
你的编译报错主要是默认配置中选中了一些不该选的配置。menuconfig中把该配置去掉即可，提交.config

@QianJiu05
Copy link
Contributor Author

QianJiu05 commented Jun 21, 2025

要先保证编译没问题。

请问action的component出问题要修吗，好像是driver的版本不对？不太敢动共用的文件，在本地编译是没问题的

其他项目选中NANO编译可以通过，理论上应该没问题。 你的编译报错主要是默认配置中选中了一些不该选的配置。menuconfig中把该配置去掉即可，提交.config

感谢，我期末周完试试

@supperthomas
Copy link
Member

supperthomas commented Jun 22, 2025

或者你可以先把出错的几个先去掉，这个可以先合并，其他的出错的，下次提PR?

@supperthomas supperthomas merged commit 1fe2a0b into RT-Thread:master Jun 24, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supperthomas supperthomas supperthomas approved these changes

@mysterywolf mysterywolf Awaiting requested review from mysterywolf mysterywolf is a code owner

Assignees

No one assigned

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QianJiu05 @supperthomas