Skip to content

[smart] rename the Group name to 'lwProcess' and optimize the error h… #10436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rbb666 merged 2 commits into from
Jul 7, 2025
+10 −33
Merged

[smart] rename the Group name to 'lwProcess' and optimize the error h… #10436

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd2caa2
[smart] rename the Group name to 'lwProcess' and optimize the error h…
BernardXiong Jun 25, 2025
527431d
[smart] Optimize error handling after command execution
BernardXiong Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/lwp/SConscript
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ CPPPATH += ['./terminal/']
if not GetDepend(['LWP_USING_RUNTIME']):
SrcRemove(src, 'lwp_runtime.c')

group = DefineGroup('lwP', src, depend = ['RT_USING_SMART'], CPPPATH = CPPPATH)
group = DefineGroup('lwProcess', src, depend = ['RT_USING_SMART'], CPPPATH = CPPPATH)

group = group + SConscript(os.path.join('vdso', 'SConscript'))
Return('group')
11 changes: 0 additions & 11 deletions components/lwp/arch/risc-v/rv64/SConscript
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions components/lwp/arch/x86/i386/SConscript
View file
Open in desktop

This file was deleted.

13 changes: 8 additions & 5 deletions components/lwp/vdso/SConscript
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,21 @@ else:
process_env['RTT_DEVICE'] = rtconfig.DEVICE

command = ["scons", "-C", vdso_arch]
clean_command = ["scons", "-C", vdso_arch, "--clean"]
if GetOption('clean'):
command = ["scons", "-C", vdso_arch, "--clean"]

if not GetOption('clean'):
try:
result = subprocess.run(command, env=process_env, check=True)
else:
result = subprocess.run(clean_command, env=process_env, check=True)
# generic error handle
except :
print('exec command: "%s" failed.' % ' '.join(command))
exit(1)
Copy link

Copilot AI Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using a bare except: which also catches system-exiting exceptions. Catch specific errors (e.g., except subprocess.CalledProcessError as e:) to prevent unintended behavior.

Suggested change
# generic error handle
except :
print('exec command: "%s" failed.' % ' '.join(command))
exit(1)
except subprocess.CalledProcessError as e:
print(f'Command "{e.cmd}" failed with return code {e.returncode}.')
exit(1)
except FileNotFoundError as e:
print(f'Command not found: {e}. Please ensure "scons" is installed and in your PATH.')
exit(1)

Copilot uses AI. Check for mistakes.

if result.returncode == 0:
print("Command executed successfully")
else:
print("Command failed with exit code:", result.returncode)
exit(1)
Copy link

Copilot AI Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using check=True, subprocess.run will raise on non-zero exits, so this manual returncode check is redundant. Consider removing it or use check=False if you need to handle exit codes explicitly.

Suggested change
if result.returncode == 0:
print("Command executed successfully")
else:
print("Command failed with exit code:", result.returncode)
exit(1)
print("Command executed successfully")

Copilot uses AI. Check for mistakes.

group = DefineGroup('vDSO', src, depend = ['RT_USING_SMART','RT_USING_VDSO'], CPPPATH = CPPPATH)
group = DefineGroup('lwProcess', src, depend = ['RT_USING_SMART','RT_USING_VDSO'], CPPPATH = CPPPATH)
Return('group')