Skip to content

Conversation

@CYFS3
Copy link
Contributor

@CYFS3 CYFS3 commented Jul 3, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#10169 把env.Append(CPPDEFINES=['STM32F091xC'])放到了bsp顶层的Sconscript中,但是keil的宏定义是从组里面读取的,所以没有添加到对应型号的宏定义

你的解决方案是什么 (what is your solution)

宏定义从env的环境读取

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the tools label Jul 3, 2025
@CYFS3
Copy link
Contributor Author

CYFS3 commented Jul 3, 2025

PixPin_2025-07-03_16-15-18
已经在 stm32\stm32f103-blue-pill 中验证


# The common part of making MDK4/5 project
def MDK45Project(tree, target, script):
def MDK45Project(env,tree, target, script):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env,后面都加一个空格

@CYFS3 CYFS3 force-pushed the fix_buding_keil branch from 1247b9d to fc03d62 Compare July 4, 2025 12:58
@Rbb666 Rbb666 merged commit 492e33d into RT-Thread:master Jul 4, 2025
58 checks passed
@CYFS3 CYFS3 deleted the fix_buding_keil branch July 5, 2025 05:32
meng-plus added a commit to meng-plus/rt-thread that referenced this pull request Jul 14, 2025
supperthomas pushed a commit that referenced this pull request Jul 15, 2025
[tools]:修复iar添加宏不完全
参考#10456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants