Skip to content

[bsp][stm32] 添加Han Lv为bsp_stm32和kernel模块的维护者 #10469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rbb666 merged 1 commit into from
Jul 10, 2025
Merged

[bsp][stm32] 添加Han Lv为bsp_stm32和kernel模块的维护者 #10469

Rbb666 merged 1 commit into from
Jul 10, 2025

Conversation

@hamburger-os
Copy link
Contributor

@hamburger-os hamburger-os commented Jul 8, 2025 •
edited
Loading

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

请求成为MAINTAINERS

你的解决方案是什么 (what is your solution)

按照群内要求发起PR并填写在线表格

请提供验证的bsp和config (provide the config and bsp)

  • BSP:无
  • .config:无
  • action:无

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jul 8, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: maintainers

Path: MAINTAINERS
Reviewers: Rbb666 kurisaW

Changed Files (Click to expand)
  • MAINTAINERS

📊 Current Review Status (Last Updated: 2025-07-10 08:06 UTC)

  • ⌛ Rbb666 Pending Review
  • ✅ kurisaW Reviewed On 2025-07-08 08:50 UTC

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Rbb666
Copy link
Member

Rbb666 commented Jul 8, 2025

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@hamburger-os 请作者签署CLA

Rbb666
Rbb666 requested changes Jul 8, 2025
View reviewed changes
MAINTAINERS Outdated
tag: bsp_stm32
path: bsp/stm32
owners: Liya Huang(wdfk-prog)<1425075683@qq.com>
owners: Liya Huang(wdfk-prog)<1425075683@qq.com>、Han Lv(hamburger-os)<296570182@qq.com>
Copy link
Member

@Rbb666 Rbb666 Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请使用，进行分隔

Copy link
Contributor Author

@hamburger-os hamburger-os Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@kurisaW
Copy link
Member

kurisaW commented Jul 8, 2025

LGTM

@Rbb666
Copy link
Member

Rbb666 commented Jul 8, 2025

有个冲突需要解决下，谢谢

@hamburger-os
Copy link
Contributor Author

hamburger-os commented Jul 8, 2025

有个冲突需要解决下，谢谢

已解决

@Rbb666
Copy link
Member

Rbb666 commented Jul 9, 2025

有个冲突需要解决下，谢谢

已解决

又存在冲突了，还麻烦解决下提交

@ReviewSun
Copy link
Contributor

ReviewSun commented Jul 9, 2025

LGTM

@hamburger-os
Copy link
Contributor Author

hamburger-os commented Jul 10, 2025

有个冲突需要解决下，谢谢

已解决

又存在冲突了，还麻烦解决下提交

已解决

Rbb666
Rbb666 requested changes Jul 10, 2025
View reviewed changes
MAINTAINERS Outdated
tag: bsp_stm32
path: bsp/stm32
owners: Liya Huang(wdfk-prog)<1425075683@qq.com>
owners: Liya Huang(wdfk-prog)<1425075683@qq.com>, Han Lv(hamburger-os)<296570182@qq.com>
Copy link
Member

@Rbb666 Rbb666 Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请按照字母顺序填写，谢谢

Copy link
Contributor Author

@hamburger-os hamburger-os Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@Rbb666
Copy link
Member

Rbb666 commented Jul 10, 2025

LGTM

@Rbb666 Rbb666 merged commit 1d75169 into RT-Thread:master Jul 10, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes

+1 more reviewer

@ReviewSun ReviewSun ReviewSun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hamburger-os @CLAassistant @Rbb666 @kurisaW @ReviewSun