Skip to content

Conversation

@unicornx
Copy link
Contributor

规范 tag 的写法

更新 Note 中对 tag 的编写要求,建议 tag 的命名直接参考模块在代码树种的路径,譬如如果模块路径是 'bsp/cvitek',那么 tag 的名字就用 'bsp_cvitek'。而且命名用小写。这样便于统一大家的 tag 的命名,否则目前看上去比较混乱。

根据以上规则,调整了现有 entry 的 tag 名字。其他不变。

其他一些文本的修改主要是限制了每行的宽度,尽量不要超过 80 列。

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

Update the tag writing requirements in the Note.
It is recommended that the tag name directly refer
to the module path in the code tree. For example,
if the module path is 'bsp/cvitek', then the tag
name should be 'bsp_cvitek'. And the name should
be lowercase.

According to the above rules, the tag name of the
existing entries are adjusted. Other changes remain
unchanged.

Other text modifications are mainly to limit the
width of each line, try not to exceed 80 columns.

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
@github-actions
Copy link

📌 Code Review Assignment

🏷️ Tag: maintainers

Path: MAINTAINERS
Reviewers: @Rbb666 @kurisaW

Changed Files (Click to expand)
  • MAINTAINERS

📊 Current Review Status (Last Updated: 2025-07-14 06:54 UTC)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@unicornx unicornx requested review from Rbb666 and kurisaW July 14, 2025 06:54
@Rbb666
Copy link
Member

Rbb666 commented Jul 14, 2025

LGTM

@Rbb666 Rbb666 merged commit f00b0a4 into RT-Thread:master Jul 14, 2025
61 checks passed
@unicornx unicornx deleted the dev-maintainer-tags branch July 22, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants