Skip to content

Conversation

@wjjsn
Copy link

@wjjsn wjjsn commented Jul 15, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

在使用stm32f407-lckfb-skystar这个BSP的时候,发现勾选USB或其他外设后出现编译错误,经检查发现没有在stm32f4xx_hal_conf.h文件自动解除对于HAL的使用的注释,导致编译时出现很多报错,而且在menuconfig已经配置了还需要再手动解除注释也麻烦。

你的解决方案是什么 (what is your solution)

现在stm32f4xx_hal_conf.h会自动根据rtconfig.h的内容自动配置

BSP:bsp/stm32/stm32f407-lckfb-skystar

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels Jul 15, 2025
@github-actions
Copy link

github-actions bot commented Jul 15, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Path: bsp/stm32
Reviewers: hamburger-os wdfk-prog Liang1795

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-lckfb-skystar/board/CubeMX_Config/Inc/stm32f4xx_hal_conf.h

📊 Current Review Status (Last Updated: 2025-07-15 04:10 UTC)

  • Liang1795 Pending Review
  • hamburger-os Pending Review
  • wdfk-prog Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@wjjsn wjjsn closed this Jul 15, 2025
@wjjsn wjjsn reopened this Jul 15, 2025
@supperthomas
Copy link
Member

这个是cube自动生成的,建议用cube生成一下,

@wjjsn
Copy link
Author

wjjsn commented Jul 15, 2025

有点不懂了,bsp完成开发之后作为使用者还是需要用到cubemx的吗?

@supperthomas
Copy link
Member

有点不懂了,bsp完成开发之后作为使用者还是需要用到cubemx的吗?

嗯,底层厂商的自动生成的文件还是建议用cube生成,这样比较准确。以后别人用cube生成也比较方便

@wjjsn
Copy link
Author

wjjsn commented Jul 15, 2025

哦,原来是这样,所以每次在menuconfig配置外设之后还要去cubemx配置一遍?这样是不是有点麻烦了,rtthread目标不是一站式的吗

@wjjsn wjjsn closed this Jul 15, 2025
@hamburger-os
Copy link
Contributor

同样建议采用cubemx生成,这在stm32上是最佳实践。你可以根据开发板原理图,把原先cubemx未开启的外设都打开

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants