Skip to content

Conversation

@eatvector
Copy link
Contributor

拉取/合并请求描述:(PR description)

fix(kernel): properly release mutexes in _thread_detach_from_mutex()

[

为什么提交这份PR (why to submit this PR)

在RT-Thread中,rt_thread_detach通过调用链_thread_detach_from_mutex->rt_mutex_release无法释放被分离线程持有的互斥锁,原因在于:rt_thread_detach要求调用线程与被分离线程不同,而rt_mutex_release则要求调用线程必须为锁的持有者,这两个相互矛盾的条件导致锁无法被正常释放。

你的解决方案是什么 (what is your solution)

可以通过重构互斥锁释放逻辑来解决这个问题:首先提取原始rt_mutex_release的核心实现为_rt_mutex_release函数,然后基于此实现新的rt_mutex_release,确保其行为与旧版本完全一致。这样既保持了原有接口的兼容性,又为后续扩展奠定了基础。

基于_rt_mutex_release,可以实现新的rt_mutex_force_release函数,该函数将绕过持有者检查逻辑。在_thread_detach_from_mutex流程中,用这个新函数替换原来的rt_mutex_release调用,这样即使当前线程不是互斥锁的持有者,也能正确释放被分离线程持有的锁资源。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the Kernel PR has src relate code label Jul 25, 2025
@github-actions
Copy link

github-actions bot commented Jul 25, 2025

📌 Code Review Assignment

🏷️ Tag: kernel

Reviewers: GorrayLi ReviewSun hamburger-os lianux-mm wdfk-prog xu18838022837

Changed Files (Click to expand)
  • src/ipc.c
  • src/thread.c

📊 Current Review Status (Last Updated: 2025-07-25 18:12 CST)

  • GorrayLi Pending Review
  • ReviewSun Pending Review
  • hamburger-os Pending Review
  • lianux-mm Pending Review
  • wdfk-prog Pending Review
  • xu18838022837 Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@eatvector eatvector marked this pull request as draft July 25, 2025 08:30
@eatvector eatvector closed this Jul 25, 2025
@eatvector eatvector deleted the fix/mutex-release-on-detach branch July 25, 2025 08:35
@eatvector eatvector restored the fix/mutex-release-on-detach branch July 25, 2025 08:54
@eatvector eatvector reopened this Jul 25, 2025
@eatvector eatvector force-pushed the fix/mutex-release-on-detach branch 3 times, most recently from ecfedf4 to 34405b0 Compare July 25, 2025 10:06
@eatvector eatvector force-pushed the fix/mutex-release-on-detach branch from 34405b0 to 930843e Compare July 25, 2025 10:11
@eatvector eatvector closed this Jul 25, 2025
@eatvector eatvector deleted the fix/mutex-release-on-detach branch July 25, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kernel PR has src relate code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant