[BSP] 添加GD32E230开发板适配 #10557

htynkn · 2025-07-28T11:15:22Z

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

添加GD32E230开发板BSP

你的解决方案是什么 (what is your solution)

下载官方hal添加到并编写GCC startup S Add support for gd32e23x RT-Thread-packages/gd32-arm-series#4 Add support for gd32e23x RT-Thread-packages/gd32-arm-cmsis#3
board/gd32/arm下新建目录 gd32e230-lckfb，并根据开发板情况添加相关配置
修改board/gd32/arm/libraries下的drv文件，以便支持GD32E230
在Ubuntu/Mac GUN GCC下测试编译，使用GD32E230开发板进行点灯、uart等验证

请提供验证的bsp和config (provide the config and bsp)

BSP: https://github.com/htynkn/rt-thread/tree/feature/add-support-for-gd32e230c/bsp/gd32/arm/gd32e230-lckfb

.config:

config.txt

验证内容	备注
Uart V2 + DMA
Uart V1 + Echo
GPIO	点灯
I2C Soft
SPI	没有DMA，后面有空另外提PR加
I2C HW	我发现GD32下面都是I2C软件实现，DMA实现后面加

action: https://github.com/htynkn/rt-thread/actions/runs/16592770198

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

CLAassistant · 2025-07-28T11:15:28Z

All committers have signed the CLA.

kurisaW · 2025-07-29T02:36:52Z

作者麻烦压缩一下提交，另外新增bsp可以参考该文件添加CI检测：

https://github.com/RT-Thread/rt-thread/blob/master/.github/ALL_BSP_COMPILE.json

htynkn · 2025-07-29T03:13:54Z

好的，我晚上验证下spi和其他模块，没问题我做文档、格式等的最终调整

作者麻烦压缩一下提交，另外新增bsp可以参考该文件添加CI检测：

https://github.com/RT-Thread/rt-thread/blob/master/.github/ALL_BSP_COMPILE.json

github-actions · 2025-07-29T03:15:30Z

📌 Code Review Assignment

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)

.github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-07-31 12:52 CST)

⌛ Rbb666 Pending Review
⌛ kurisaW Pending Review
⌛ supperthomas Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

htynkn · 2025-07-29T06:08:33Z

Action 目前是失败的，make distribution fail

make distribution....
=> gd32e230-lckfb
=> start dist handle
=> copy gd32 bsp library
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType':
  File "/home/runner/work/rt-thread/rt-thread/bsp/gd32/arm/gd32e230-lckfb/SConstruct", line 74:
    DoBuilding(TARGET, objs)
  File "/home/runner/work/rt-thread/rt-thread/tools/building.py", line 803:
    EndBuilding(target, program)
  File "/home/runner/work/rt-thread/rt-thread/tools/building.py", line 927:
    MkDist(program, BSP_ROOT, Rtt_Root, Env, project_name, project_path)
  File "/home/runner/work/rt-thread/rt-thread/tools/mkdist.py", line 195:
    dist_handle(BSP_ROOT, dist_dir)
  File "/home/runner/work/rt-thread/rt-thread/bsp/gd32/arm/gd32e230-lckfb/rtconfig.py", line 148:
    dist_do_building(BSP_ROOT, dist_dir)
  File "/home/runner/work/rt-thread/rt-thread/bsp/gd32/arm/tools/sdk_dist.py", line 30:
    bsp_copy_files(os.path.join(library_path, rtconfig.BSP_LIBRARY_TYPE),
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/posixpath.py", line 90:
    genericpath._check_arg_types('join', a, *p)
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/genericpath.py", line 152:
    raise TypeError(f'{funcname}() argument must be str, bytes, or '

但是我看所有GD32 BSP都是BSP_LIBRARY_TYPE = None，是我哪里缺了什么配置吗？

kurisaW · 2025-07-29T08:14:48Z

bsp/gd32/arm/gd32e230-lckfb/board/Kconfig

+
+menu "Hardware Drivers Config"
+
+menu "SOC Series"


这里的写法参考一下其他可以通过CI编译的GD系列bsp

这里的写法参考一下其他可以通过CI编译的GD系列bsp

done

htynkn · 2025-07-29T10:11:04Z

Action 目前是失败的，make distribution fail

make distribution....
=> gd32e230-lckfb
=> start dist handle
=> copy gd32 bsp library
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType':
  File "/home/runner/work/rt-thread/rt-thread/bsp/gd32/arm/gd32e230-lckfb/SConstruct", line 74:
    DoBuilding(TARGET, objs)
  File "/home/runner/work/rt-thread/rt-thread/tools/building.py", line 803:
    EndBuilding(target, program)
  File "/home/runner/work/rt-thread/rt-thread/tools/building.py", line 927:
    MkDist(program, BSP_ROOT, Rtt_Root, Env, project_name, project_path)
  File "/home/runner/work/rt-thread/rt-thread/tools/mkdist.py", line 195:
    dist_handle(BSP_ROOT, dist_dir)
  File "/home/runner/work/rt-thread/rt-thread/bsp/gd32/arm/gd32e230-lckfb/rtconfig.py", line 148:
    dist_do_building(BSP_ROOT, dist_dir)
  File "/home/runner/work/rt-thread/rt-thread/bsp/gd32/arm/tools/sdk_dist.py", line 30:
    bsp_copy_files(os.path.join(library_path, rtconfig.BSP_LIBRARY_TYPE),
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/posixpath.py", line 90:
    genericpath._check_arg_types('join', a, *p)
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/genericpath.py", line 152:
    raise TypeError(f'{funcname}() argument must be str, bytes, or '

但是我看所有GD32 BSP都是BSP_LIBRARY_TYPE = None，是我哪里缺了什么配置吗？

打包脚本有问题，现在hal是通过env下载的，这个dist脚本需要重新思考规划下。我临时修复了下

kurisaW · 2025-07-29T11:33:08Z

[Bsp Scons Compile](https://github.com/RT-Thread/rt-thread/actions/runs/16592740817/job/46937831429?pr=10557#annotation:21:3130)
build gd32/arm/gd32e230-lckfb hw_drv_onchip.adc0 failed.

可以再关注一下hw_drv_onchip.adc0的问题

另外编码问题也请关注一下:

htynkn · 2025-07-29T12:50:05Z

[Bsp Scons Compile](https://github.com/RT-Thread/rt-thread/actions/runs/16592740817/job/46937831429?pr=10557#annotation:21:3130)
build gd32/arm/gd32e230-lckfb hw_drv_onchip.adc0 failed.

可以再关注一下hw_drv_onchip.adc0的问题

另外编码问题也请关注一下:

all done

Rbb666 · 2025-07-31T04:45:25Z

bsp/gd32/arm/libraries/gd32_drivers/drv_rtc.c


    rcu_periph_clock_enable(RCU_PMU);
    pmu_backup_write_enable();
+    #ifndef SOC_SERIES_GD32E23x


缩进需要修改下

缩进需要修改下

done

github-actions bot added BSP BSP: GD32 BSP related with GD32 labels Jul 28, 2025

htynkn changed the title ~~[BSP] 添加GD32E230开发板适配~~ [BSP] 添加GD32E230开发板适配 [Draft/进行中的草稿] Jul 28, 2025

github-actions bot added the action github action yml imporve label Jul 29, 2025

htynkn force-pushed the feature/add-support-for-gd32e230c branch from 8d8ca6b to a098208 Compare July 29, 2025 03:49

add bsp support for gd32e230-lckfb

99e92db

htynkn force-pushed the feature/add-support-for-gd32e230c branch from 737787b to 99e92db Compare July 29, 2025 05:47

htynkn marked this pull request as ready for review July 29, 2025 06:07

htynkn requested a review from supperthomas as a code owner July 29, 2025 06:07

htynkn changed the title ~~[BSP] 添加GD32E230开发板适配 [Draft/进行中的草稿]~~ [BSP] 添加GD32E230开发板适配 Jul 29, 2025

kurisaW reviewed Jul 29, 2025

View reviewed changes

htynkn added 2 commits July 29, 2025 09:26

polish Kconfig

000216d

skip none for bsp dist

042700c

htynkn added 2 commits July 29, 2025 12:13

fix adc issue

ad97cfc

use formatting py to format code

398447c

supperthomas added the BSP: new bsp board New added bsp, need sync action label Jul 30, 2025

supperthomas approved these changes Jul 30, 2025

View reviewed changes

kurisaW requested a review from Rbb666 July 30, 2025 08:37

Rbb666 reviewed Jul 31, 2025

View reviewed changes

fix format

84f8eb8

Rbb666 approved these changes Jul 31, 2025

View reviewed changes

supperthomas merged commit c55cbc5 into RT-Thread:master Jul 31, 2025
61 checks passed

htynkn deleted the feature/add-support-for-gd32e230c branch July 31, 2025 09:32

[BSP] 添加GD32E230开发板适配 #10557

[BSP] 添加GD32E230开发板适配 #10557

Uh oh!

Conversation

htynkn commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

CLAassistant commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kurisaW commented Jul 29, 2025

Uh oh!

htynkn commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: workflow

📊 Current Review Status (Last Updated: 2025-07-31 12:52 CST)

📝 Review Instructions

Uh oh!

htynkn commented Jul 29, 2025

Uh oh!

kurisaW Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

htynkn Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

htynkn commented Jul 29, 2025

Uh oh!

kurisaW commented Jul 29, 2025

Uh oh!

htynkn commented Jul 29, 2025

Uh oh!

Rbb666 Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

htynkn Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

htynkn commented Jul 28, 2025 •

edited

Loading

CLAassistant commented Jul 28, 2025 •

edited

Loading

github-actions bot commented Jul 29, 2025 •

edited

Loading