Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion components/drivers/can/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,26 @@ if RT_USING_CAN
config RT_CAN_USING_HDR
bool "Enable CAN hardware filter"
default n

config RT_CAN_USING_CANFD
bool "Enable CANFD support"
default n
endif

config RT_CANMSG_BOX_SZ
int "CAN message box size"
default 16
help
Set the size of the CAN message box.

config RT_CANSND_BOX_NUM
int "Number of CAN send queues"
default 1
help
Set the number of CAN send queues.

config RT_CANSND_MSG_TIMEOUT
int "CAN send message timeout"
default 100
help
Set the timeout for CAN send messages.
endif
41 changes: 28 additions & 13 deletions components/drivers/can/dev_can.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2006-2024 RT-Thread Development Team
* Copyright (c) 2006-2025, RT-Thread Development Team
*
* SPDX-License-Identifier: Apache-2.0
*
Expand Down Expand Up @@ -165,8 +165,16 @@ rt_inline int _can_int_tx(struct rt_can_device *can, const struct rt_can_msg *da
goto err_ret;
}

can->status.sndchange = 1;
rt_completion_wait(&(tx_tosnd->completion), RT_WAITING_FOREVER);
can->status.sndchange |= 1<<no;
if (rt_completion_wait(&(tx_tosnd->completion), RT_CANSND_MSG_TIMEOUT) != RT_EOK)
{
level = rt_hw_interrupt_disable();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里开关全局中断是否会产生风险?

rt_list_insert_before(&tx_fifo->freelist, &tx_tosnd->list);
can->status.sndchange &= ~ (1<<no);
rt_hw_interrupt_enable(level);
rt_sem_release(&(tx_fifo->sem));
goto err_ret;
}

level = rt_hw_interrupt_disable();
result = tx_tosnd->result;
Expand Down Expand Up @@ -237,8 +245,12 @@ rt_inline int _can_int_tx_priv(struct rt_can_device *can, const struct rt_can_ms
{
continue;
}
can->status.sndchange = 1;
rt_completion_wait(&(tx_fifo->buffer[no].completion), RT_WAITING_FOREVER);
can->status.sndchange |= 1<<no;
if (rt_completion_wait(&(tx_fifo->buffer[no].completion), RT_CANSND_MSG_TIMEOUT) != RT_EOK)
{
can->status.sndchange &= ~ (1<<no);
continue;
}

result = tx_fifo->buffer[no].result;
if (result == RT_CAN_SND_RESULT_OK)
Expand Down Expand Up @@ -892,16 +904,18 @@ void rt_hw_can_isr(struct rt_can_device *can, int event)
no = event >> 8;
tx_fifo = (struct rt_can_tx_fifo *) can->can_tx;
RT_ASSERT(tx_fifo != RT_NULL);

if ((event & 0xff) == RT_CAN_EVENT_TX_DONE)
if (can->status.sndchange&(1<<no))
{
tx_fifo->buffer[no].result = RT_CAN_SND_RESULT_OK;
}
else
{
tx_fifo->buffer[no].result = RT_CAN_SND_RESULT_ERR;
if ((event & 0xff) == RT_CAN_EVENT_TX_DONE)
{
tx_fifo->buffer[no].result = RT_CAN_SND_RESULT_OK;
}
else
{
tx_fifo->buffer[no].result = RT_CAN_SND_RESULT_ERR;
}
rt_completion_done(&(tx_fifo->buffer[no].completion));
}
rt_completion_done(&(tx_fifo->buffer[no].completion));
break;
}
}
Expand Down Expand Up @@ -972,3 +986,4 @@ int cmd_canstat(int argc, void **argv)
}
MSH_CMD_EXPORT_ALIAS(cmd_canstat, canstat, stat can device status);
#endif

6 changes: 5 additions & 1 deletion components/drivers/include/drivers/dev_can.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2006-2024 RT-Thread Development Team
* Copyright (c) 2006-2025, RT-Thread Development Team
*
* SPDX-License-Identifier: Apache-2.0
*
Expand All @@ -21,6 +21,9 @@
#ifndef RT_CANSND_BOX_NUM
#define RT_CANSND_BOX_NUM 1
#endif
#ifndef RT_CANSND_MSG_TIMEOUT
#define RT_CANSND_MSG_TIMEOUT 100
#endif

enum CAN_DLC
{
Expand Down Expand Up @@ -541,3 +544,4 @@ void rt_hw_can_isr(struct rt_can_device *can, int event);
/*! @}*/

#endif /*__DEV_CAN_H*/