Skip to content

Conversation

@htynkn
Copy link
Contributor

@htynkn htynkn commented Jul 31, 2025

拉取/合并请求描述:(PR description)

为什么提交这份PR (why to submit this PR)

为gd32e230 添加硬件i2c支持

你的解决方案是什么 (what is your solution)

之前gd32的i2c都是软件模拟的,无法复用。
新增drv_hw_i2c.h 和 drv_hw_i2c.c ,并在Kconfig新增启用和速率配置。

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/gd32/arm/gd32e230-lckfb
  • .config:
    BSP_USING_HW_I2C=y
    BSP_USING_HW_I2C0=y
    BSP_HW_I2C0_CLOCK_SPEED=1000000
  • action:

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP BSP: GD32 BSP related with GD32 labels Jul 31, 2025
@htynkn htynkn force-pushed the feature/add-gd32-i2c-hard branch from ae2f068 to 03a9418 Compare July 31, 2025 14:00
@htynkn htynkn marked this pull request as ready for review July 31, 2025 14:16
@htynkn htynkn marked this pull request as draft July 31, 2025 22:50
@htynkn
Copy link
Contributor Author

htynkn commented Jul 31, 2025

经过更多测试,和rtc同时开有问题,异常处理需要完善下,pr先转为草稿状态

@htynkn htynkn changed the title [Driver] add i2c hardware support for gd32e230 [Driver] add i2c hardware support for gd32e230 [草稿/进行中] Jul 31, 2025
@htynkn htynkn closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: GD32 BSP related with GD32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant