Skip to content

Conversation

@illustriousness
Copy link
Contributor

@illustriousness illustriousness commented Aug 6, 2025

Solution: gd32_uart_gpio_init 不开中断
等驱动框架初始化好fifo后通过 device_control 开中断
以下是drv_usart.c 中注册进驱动框架的 device_control 函数

static rt_err_t gd32_uart_control(struct rt_serial_device *serial, int cmd, void *arg)
{
    struct gd32_uart *uart;

    RT_ASSERT(serial != RT_NULL);
    uart = (struct gd32_uart *)serial->parent.user_data;

    switch (cmd)
    {
    case RT_DEVICE_CTRL_CLR_INT:
        /* disable rx irq */
        NVIC_DisableIRQ(uart->irqn);
        /* disable interrupt */
        usart_interrupt_disable(uart->uart_periph, USART_INT_RBNE);

        break;
    case RT_DEVICE_CTRL_SET_INT:
        /* enable rx irq */
        NVIC_EnableIRQ(uart->irqn);
        /* enable interrupt */
        usart_interrupt_enable(uart->uart_periph, USART_INT_RBNE);
        break;
    }

    return RT_EOK;
}

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

Solution: gd32_uart_gpio_init 不开中断
等驱动框架初始化好fifo后通过 device_control 开中断
Signed-off-by: Yucai Liu <1486344514@qq.com>
@github-actions github-actions bot added BSP BSP: GD32 BSP related with GD32 labels Aug 6, 2025
@illustriousness illustriousness changed the title [Fix] <bsp>:gd32_uart_gpio_init 过早开中断触发断言rx_fifo == NULL [Fix] <bsp>:bsp/gd32/arm/libraries/gd32_drivers/drv_usart.cgd32_uart_gpio_init 过早开中断触发断言rx_fifo == NULL Aug 6, 2025
@illustriousness illustriousness changed the title [Fix] <bsp>:bsp/gd32/arm/libraries/gd32_drivers/drv_usart.cgd32_uart_gpio_init 过早开中断触发断言rx_fifo == NULL [Fix] <bsp>:bsp/gd32/arm/libraries/gd32_drivers/drv_usart.c 函数gd32_uart_gpio_init 过早开中断触发断言rx_fifo == NULL Aug 6, 2025
@Rbb666 Rbb666 merged commit 83909b2 into RT-Thread:master Aug 6, 2025
35 checks passed
@illustriousness illustriousness deleted the fix_gduart branch October 12, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: GD32 BSP related with GD32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants