update(cherryusb): update to v1.5.2 #10588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sakumisu <1203593632@qq.com>
📌 Code Review Assignment🏷️ Tag: componentsReviewers: @Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-08-08 11:10 CST)
📝 Review Instructions
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates CherryUSB from version 1.5.1 to 1.5.2, bringing configuration normalization, bug fixes, and enhanced functionality across multiple USB controllers including DWC2, MUSB, EHCI, and others.
Key changes include:
- Configuration constant renaming from
CONFIG_USBHOST_PIPE_NUM/CONFIG_USBDEV_EP_NUMto specific controller constants - Bug fixes for memory management and URB handling
- Performance optimizations and new platform support
Reviewed Changes
Copilot reviewed 52 out of 53 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| port/rp2040/usb_hc_rp2040.c | Updates pipe configuration constants and improves URB cleanup |
| port/rp2040/usb_dc_rp2040.c | Replaces generic endpoint constants with USB-specific ones |
| port/musb/usb_hc_musb.c | Extensive MUSB controller updates with register access improvements |
| port/dwc2/usb_hc_dwc2.c | DWC2 host controller optimizations and bug fixes |
| port/ehci/usb_hc_ehci.c | EHCI controller memory management improvements |
| common/usb_version.h | Version bump to v1.5.2 |
Comments suppressed due to low confidence (2)
components/drivers/usb/cherryusb/port/musb/usb_hc_musb.c:494
- The function
musb_pipe_allocis missing thebusparameter that is used within the function body. The function signature should includestruct usbh_bus *busparameter.
static int musb_pipe_alloc(void)
components/drivers/usb/cherryusb/port/dwc2/usb_hc_dwc2.c:1353
- The magic number 200000 should be defined as a named constant to improve code readability and maintainability.
dwc2_urb_waitup(urb);
Rbb666
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up