Skip to content

Conversation

@JamieTx
Copy link
Contributor

@JamieTx JamieTx commented Aug 18, 2025

拉取/合并请求描述:(PR description)

[
Update bsp drivers for F334.
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions github-actions bot added the BSP label Aug 18, 2025
@github-actions
Copy link

github-actions bot commented Aug 18, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_hc32

Reviewers: levizh

Changed Files (Click to expand)
  • bsp/hc32/README.md
  • bsp/hc32/ev_hc32f334_lqfp64/.ci/attachconfig/ci.attachconfig.yml
  • bsp/hc32/ev_hc32f334_lqfp64/README.md
  • bsp/hc32/ev_hc32f334_lqfp64/board/Kconfig
  • bsp/hc32/ev_hc32f334_lqfp64/board/board.c
  • bsp/hc32/ev_hc32f334_lqfp64/board/board_config.c
  • bsp/hc32/ev_hc32f334_lqfp64/board/board_config.h
  • bsp/hc32/ev_hc32f334_lqfp64/board/config/adc_config.h
  • bsp/hc32/ev_hc32f334_lqfp64/board/config/dac_config.h
  • bsp/hc32/ev_hc32f334_lqfp64/board/config/irq_config.h
  • bsp/hc32/ev_hc32f334_lqfp64/board/config/pm_config.h
  • bsp/hc32/ev_hc32f334_lqfp64/board/config/pwm_tmr_config.h
  • bsp/hc32/ev_hc32f334_lqfp64/board/config/tmr_capture_config.h
  • bsp/hc32/ev_hc32f334_lqfp64/board/linker_scripts/link.icf
  • bsp/hc32/ev_hc32f334_lqfp64/bsp_compile_ci.bat
  • bsp/hc32/ev_hc32f334_lqfp64/figures/board.png
  • bsp/hc32/ev_hc32f334_lqfp64/project.uvprojx
  • bsp/hc32/ev_hc32f334_lqfp64/template.uvprojx
  • bsp/hc32/ev_hc32f448_lqfp80/.ci/attachconfig/ci.attachconfig.yml
  • bsp/hc32/ev_hc32f448_lqfp80/README.md
  • bsp/hc32/ev_hc32f448_lqfp80/board/Kconfig
  • bsp/hc32/ev_hc32f448_lqfp80/board/board_config.c
  • bsp/hc32/ev_hc32f448_lqfp80/board/board_config.h
  • bsp/hc32/ev_hc32f448_lqfp80/board/config/irq_config.h
  • bsp/hc32/ev_hc32f448_lqfp80/board/config/tmr_capture_config.h
  • bsp/hc32/ev_hc32f448_lqfp80/board/drv_config.h
  • bsp/hc32/ev_hc32f448_lqfp80/board/linker_scripts/link.icf
  • bsp/hc32/ev_hc32f448_lqfp80/bsp_compile_ci.bat
  • bsp/hc32/ev_hc32f448_lqfp80/project.uvprojx
  • bsp/hc32/ev_hc32f448_lqfp80/template.uvprojx

📊 Current Review Status (Last Updated: 2025-08-22 11:24 CST)

  • levizh Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@JamieTx JamieTx changed the title Update bsp drivers for F334. [bsp][hc32] Update bsp drivers for F334. Aug 20, 2025
@levizh
Copy link
Contributor

levizh commented Aug 20, 2025

HC32F472最高主频120MHz,请修改相关文件

@JamieTx
Copy link
Contributor Author

JamieTx commented Aug 20, 2025

HC32F472最高主频120MHz,请修改相关文件

已修改

Copy link
Contributor

@levizh levizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamieTx
Copy link
Contributor Author

JamieTx commented Aug 22, 2025

@Rbb666 请帮忙看下,还有什么需要处理的?

@Rbb666 Rbb666 closed this Aug 22, 2025
@Rbb666 Rbb666 reopened this Aug 22, 2025
@Rbb666 Rbb666 merged commit 78cd7c4 into RT-Thread:master Aug 22, 2025
71 checks passed
@Rbb666 Rbb666 added this to the v5.2.2 milestone Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants