Skip to content

Conversation

@MuChenger
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

update gd32 i2c driver

请提供验证的bsp和config (provide the config and bsp)

  • BSP: gd32/arm/gd32h759i-eval

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added BSP BSP: GD32 BSP related with GD32 labels Aug 27, 2025
@MuChenger MuChenger closed this Aug 27, 2025
@MuChenger MuChenger reopened this Aug 27, 2025
default n
endif

menuconfig BSP_USING_SOFT_I2C
Copy link
Member

@kurisaW kurisaW Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

软件i2c已经集成到驱动框架中了,这里无需再加配置,另外GD32的软件i2c驱动也可以删掉了,对应的构建脚本配置项也请对应删除

@MuChenger MuChenger closed this Aug 28, 2025
@MuChenger MuChenger reopened this Aug 28, 2025
@Rbb666 Rbb666 merged commit 6a9d218 into RT-Thread:master Aug 28, 2025
34 of 35 checks passed
@MuChenger MuChenger deleted the gd32h7 branch August 29, 2025 01:51
tomjielii pushed a commit to tomjielii/rt-thread that referenced this pull request Sep 9, 2025
[bsp][renesas] add RA2E2-EK for CI check

[bsp][renesas] add IAR enviroment entry function and startup_check script
tomjielii pushed a commit to tomjielii/rt-thread that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: GD32 BSP related with GD32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants