Skip to content

Conversation

@MuChenger
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

更新GD32 SPI驱动

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions github-actions bot added BSP BSP: GD32 BSP related with GD32 labels Sep 1, 2025
@Rbb666 Rbb666 requested a review from Copilot September 1, 2025 11:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GD32 SPI driver to improve GPIO configuration, add support for new MCU series, and enhance functionality with SPI5 support and better CS pin handling.

  • Refactors GPIO pin configuration to handle SCK, MISO, and MOSI pins independently instead of as a combined group
  • Adds support for GD32H7xx and GD32F5xx series MCUs with appropriate GPIO speed settings and flag handling
  • Introduces SPI5 peripheral support and modernizes CS pin management using the RT-Thread device framework

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
bsp/gd32/arm/libraries/gd32_drivers/drv_spi.h Updates structure definition to separate GPIO clocks and ports for individual pin control
bsp/gd32/arm/libraries/gd32_drivers/drv_spi.c Major refactoring of GPIO initialization, adds GD32H7xx/F5xx support, SPI5 configuration, and modern CS handling
bsp/gd32/arm/gd32h759i-eval/board/Kconfig Adds SPI configuration options for GD32H759I evaluation board
bsp/gd32/arm/gd32527I-eval/board/Kconfig Expands SPI configuration options to include all SPI peripherals (SPI0-SPI5)

Comment on lines 395 to 397
LOG_D("%s transfer prepare and start", spi_drv->config->bus_name);
LOG_D("%s sendbuf: %X, recvbuf: %X, length: %d",
spi_drv->config->bus_name,
Copy link

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[bug/错误]: Undefined variable spi_drv is used in debug logging statements.

English: The variable spi_drv is not defined in the spixfer function scope. The correct variable should be spi_device which is defined at line 375.

中文:变量 spi_drvspixfer 函数作用域中未定义。应该使用在第375行定义的正确变量 spi_device

Example/示例:

LOG_D("%s transfer prepare and start", spi_device->bus_name);
LOG_D("%s sendbuf: %X, recvbuf: %X, length: %d",
spi_device->bus_name,
(uint32_t)message->send_buf,
(uint32_t)message->recv_buf, message->length);
Suggested change
LOG_D("%s transfer prepare and start", spi_drv->config->bus_name);
LOG_D("%s sendbuf: %X, recvbuf: %X, length: %d",
spi_drv->config->bus_name,
LOG_D("%s transfer prepare and start", spi_device->config->bus_name);
LOG_D("%s sendbuf: %X, recvbuf: %X, length: %d",
spi_device->config->bus_name,

Copilot uses AI. Check for mistakes.
@Rbb666 Rbb666 merged commit f8a37bc into RT-Thread:master Sep 2, 2025
36 checks passed
tomjielii pushed a commit to tomjielii/rt-thread that referenced this pull request Sep 9, 2025
tomjielii pushed a commit to tomjielii/rt-thread that referenced this pull request Sep 12, 2025
@Rbb666 Rbb666 added this to the v5.2.2 milestone Sep 23, 2025
@MuChenger MuChenger deleted the GD32_SPI branch October 29, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: GD32 BSP related with GD32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants