-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[bsp][renesas]add ra2a1 drvices #10682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📌 Code Review Assignment🏷️ Tag: bsp_renesasReviewers: kurisaW Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-09-10 15:51 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds hardware peripheral drivers configuration for the Renesas RA2A1-EK BSP, including support for SCI (Serial Communication Interface), I2C, PWM, and SPI controllers.
- Adds SCI controller configuration with support for SPI, I2C, and UART modes across multiple channels (SCI0, SCI1, SCI9)
- Introduces hardware I2C bus configuration for I2C0 and I2C1 controllers
- Implements PWM configuration for GPT0-GPT6 timers with 32-bit output capability
- Adds dedicated SPI bus configuration for SPI0 and SPI1 controllers
bsp/renesas/ra2a1-ek/board/Kconfig
Outdated
| default 0 | ||
| endif | ||
| endif | ||
|
|
Copilot
AI
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[spelling]: Extra trailing whitespace detected / 检测到多余的尾随空白字符
English: There are trailing spaces on this otherwise empty line. Please remove the trailing whitespace to maintain clean code formatting.
中文:这个空行包含了尾随空格。请移除尾随空白字符以保持代码格式的整洁。
bsp/renesas/ra2a1-ek/board/Kconfig
Outdated
| endif | ||
| endif | ||
|
|
||
|
|
Copilot
AI
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[spelling]: Extra trailing whitespace detected / 检测到多余的尾随空白字符
English: There are trailing spaces on this otherwise empty line. Please remove the trailing whitespace to maintain clean code formatting.
中文:这个空行包含了尾随空格。请移除尾随空白字符以保持代码格式的整洁。
bsp/renesas/ra2a1-ek/board/Kconfig
Outdated
| config BSP_USING_PWM6 | ||
| bool "Enable GPT6 (32-Bits) output PWM" | ||
| default n | ||
|
|
Copilot
AI
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[spelling]: Extra trailing whitespace detected / 检测到多余的尾随空白字符
English: There are trailing spaces on this otherwise empty line. Please remove the trailing whitespace to maintain clean code formatting.
中文:这个空行包含了尾随空格。请移除尾随空白字符以保持代码格式的整洁。
bsp/renesas/ra2a1-ek/board/Kconfig
Outdated
| bool "Enable SPI BUS" | ||
| default n | ||
| select RT_USING_SPI | ||
| if BSP_USING_SPI |
Copilot
AI
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[spelling]: Extra trailing whitespace detected / 检测到多余的尾随空白字符
English: There is a trailing space after "BSP_USING_SPI". Please remove the trailing whitespace to maintain clean code formatting.
中文:在"BSP_USING_SPI"后面有尾随空格。请移除尾随空白字符以保持代码格式的整洁。
| if BSP_USING_SPI | |
| if BSP_USING_SPI |
|
@CYFS3 AI提出的一些格式化建议麻烦进行修改 |
|
LGTM |
ccb74bf to
a2a4dd6
Compare
已经修改 |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
添加spi、i2c、 sci和pwm,均在板端验证过没问题。
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up