utest: unify utest name #10698
Merged
utest: unify utest name #10698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More details see PR RT-Thread#10681. As utest cases are currently moving out of `examples/utest/testcases` into their own module directories, the naming rule needs to change accordingly. Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
github-actions
bot
added
BSP
Doc
📌 Code Review Assignment🏷️ Tag: bsp_k230Reviewers: unicornx Changed Files (Click to expand)
🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
🏷️ Tag: documentationReviewers: CXSforHPU GorrayLi lianux-mm unicornx Changed Files (Click to expand)
🏷️ Tag: kernelReviewers: GorrayLi ReviewSun hamburger-os lianux-mm wdfk-prog xu18838022837 Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-09-15 17:14 CST)
📝 Review Instructions
|
Rbb666
reviewed
Sep 15, 2025
| } | ||
|
|
||
| UTEST_TC_EXPORT(utest_do_tc, "utest", RT_NULL, RT_NULL, 10); | ||
| UTEST_TC_EXPORT(utest_do_tc, "components.utilities.utest.utest", RT_NULL, RT_NULL, 10); |
Contributor
Author
There was a problem hiding this comment.
这块是不是多写了一个 utest
不是的，这里 module prefix 就是 “components.utilities.utest”
Member
There was a problem hiding this comment.
如果是属于utest框架的建议可以修改全名为components.utilities.utest
Contributor
Author
There was a problem hiding this comment.
如果是属于utest框架的建议可以修改全名为
components.utilities.utest
哦，是这样的，"components.utilities.utest.utest" 是全名，其中 “components.utilities.utest” 是 module prefix，最后一个 utest 是 “test function"。因为原来就是这么起的名字，我就没有改。
不过这个可能看上去怪怪的，导致了你们的误解，我把 function 部分改成 uassert 吧，因为这里的测试主要就是在验证那些 uassert 的 API。
unicornx
requested review from
Rbb666 and
kurisaW
and removed request for
Cathy-lulu and
mysterywolf
The names of the utest cases defined in their respective modules have been updated. Some utest case names are not yet in their respective modules because their paths need to be finalized before their unique names can be determined. Currently, these names do not appear to conflict with the unified names. These include: - utest cases still in examples - bsp/qemu-virt64-riscv/applications/test/test_vector/test_vector.c. The entire test case should probably be placed in libcpu/risc-v rather than bsp. Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
unicornx
force-pushed
the
dev-unify-utest-name
branch
from
a6d91d6 to
5e177f1
Compare
Contributor
Author
Contributor
|
LGTM |
kurisaW
approved these changes
Sep 15, 2025
Rbb666
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本 PR 用于解决
本 PR 由两个 commit 组成（merge 时请保留两个 commit ，不要 压缩。）：
还有一些未放在各自所属模块下的 utest case 的名字，因为需要最终确定这些 case 所在的路径后才好确定它们的唯一的名字，所以暂时还没有修改。它们包括：
bsp/qemu-virt64-riscv/applications/test/test_vector/test_vector.c， 这个测试用例感觉应该放到libcpu/rsic-v下去而不是放在 bsp 下。这些 case 会最终按照分布式的原则移动所在目录，新的名字会跟随这些工作逐步平滑完成。目前这些case 的名字和已经统一的名字看上去暂时不会冲突。
以上两个问题已经记录在 #10661 备忘。