Skip to content

Conversation

@miaolei7456
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

添加EK-RA4E2的支持,目前使用的是FSP6.0版本
存在的问题:
使用FSP重新生成代码的时候,会在当前目录重新生成bsp_linker_info.h,直接使用env编译的话需要手动删除,keil没有影响

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@miaolei7456 miaolei7456 requested a review from Rbb666 as a code owner September 15, 2025 17:11
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 15, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

Reviewers: kurisaW

Changed Files (Click to expand)
  • bsp/renesas/ra4e2-ek/.api_xml
  • bsp/renesas/ra4e2-ek/.config
  • bsp/renesas/ra4e2-ek/.gitignore
  • bsp/renesas/ra4e2-ek/.ignore_format.yml
  • bsp/renesas/ra4e2-ek/.secure_azone
  • bsp/renesas/ra4e2-ek/.secure_rzone
  • bsp/renesas/ra4e2-ek/.secure_xml
  • bsp/renesas/ra4e2-ek/.settings/standalone.prefs
  • bsp/renesas/ra4e2-ek/Kconfig
  • bsp/renesas/ra4e2-ek/README.md
  • bsp/renesas/ra4e2-ek/SConscript
  • bsp/renesas/ra4e2-ek/SConstruct
  • bsp/renesas/ra4e2-ek/board/Kconfig
  • bsp/renesas/ra4e2-ek/board/SConscript
  • bsp/renesas/ra4e2-ek/board/board.h
  • bsp/renesas/ra4e2-ek/board/ports/SConscript
  • bsp/renesas/ra4e2-ek/board/ports/gpio_cfg.h
  • bsp/renesas/ra4e2-ek/bsp_linker_info.h
  • bsp/renesas/ra4e2-ek/buildinfo.gpdsc
  • bsp/renesas/ra4e2-ek/configuration.xml
  • bsp/renesas/ra4e2-ek/docs/picture/ek-ra4e2-TXRX.png
  • bsp/renesas/ra4e2-ek/docs/picture/ek-ra4e2-board-led.png
  • bsp/renesas/ra4e2-ek/docs/picture/ek-ra4e2-board.png
  • bsp/renesas/ra4e2-ek/docs/picture/ek-ra4e2-fsp_configure.png
  • bsp/renesas/ra4e2-ek/docs/picture/jflash1.png
  • bsp/renesas/ra4e2-ek/docs/picture/jflash2.png
  • bsp/renesas/ra4e2-ek/docs/picture/jflash3.png
  • bsp/renesas/ra4e2-ek/docs/picture/readme_faq1.png
  • bsp/renesas/ra4e2-ek/fsp_gen.scat
  • bsp/renesas/ra4e2-ek/memory_regions.scat

📊 Current Review Status (Last Updated: 2025-09-19 21:41 CST)

  • kurisaW Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions bot added BSP BSP: Renesas BSP related with Renesas labels Sep 15, 2025
## 外设支持

本 BSP 目前对外设的支持情况如下:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处外设是否都通过验证,如验证成功请提交运行截图,否则请修改为不支持

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改readme,运行截图如下
image


## 开发板介绍

基于瑞萨 RA6M4 MCU 开发的 CPK-RA6M4 MCU 评估板,通过灵活配置软件包和 IDE,可帮助用户对 RA6M4 MCU 群组的特性轻松进行评估,并对嵌入系统应用程序进行开发。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外你这份readme并不是对应你的bsp信息,请同步修改

#define RA_IRQ_MAX 16

/* PIN to IRQx table */
#define PIN2IRQX_TABLE \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的引脚中断是否是依据fsp的中断引脚进行对应配置?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参考了fsp中断及参考bsp下ra4e2-eco进行配置
image

@@ -0,0 +1,59 @@
menu "Hardware Drivers Config"

config SOC_R7FA4E2B9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外你的芯片型号并不是这款,请依据configuration.xml中芯片的定义截取长度并进行命名

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最新修改中对应修改,感谢

@supperthomas supperthomas added the BSP: new bsp board New added bsp, need sync action label Sep 17, 2025
@miaolei7456 miaolei7456 requested a review from kurisaW September 18, 2025 16:32
@Rbb666
Copy link
Member

Rbb666 commented Sep 19, 2025

@miaolei7456 这个svd可以不用上传,readme里面给个外链会好一些,体积太大了:
image

工程未使用此文件,
此文件在renesas bsp中已有一份,此文件可以删除
bsp\renesas\ra4e2-eco\script\R7FA4E2B9.svd
@miaolei7456
Copy link
Contributor Author

@Rbb666 R7FA4E2B9.svd此文件已删除
已确认工程未使用此文件。
另外,此文件在renesas bsp中已有一份,此文件可以删除。

@Rbb666
Copy link
Member

Rbb666 commented Sep 19, 2025

每太看懂唉,为啥会提交两份BSP上来?是不是提交错误了,麻烦检查下

image

@miaolei7456
Copy link
Contributor Author

@Rbb666 感谢,已修正

@Rbb666 Rbb666 requested a review from Copilot September 20, 2025 00:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds BSP support for the Renesas EK-RA4E2 evaluation board, utilizing FSP 6.0. The implementation provides essential CMSIS 6 ARM Cortex-M core files needed to support this embedded platform for RT-Thread. The BSP enables development on the RA4E2 microcontroller with comprehensive ARM core register access and interrupt handling capabilities.

Key Changes:

  • Added complete CMSIS 6 ARM Cortex-M core library support
  • Implemented ARM core register definitions and hardware abstraction layers
  • Provided compiler-specific intrinsics for GCC, Clang, and ARM Clang
  • Added Armv7-M and Armv8-M architecture support components

Reviewed Changes

Copilot reviewed 48 out of 163 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cmsis_gcc_m.h GCC-specific ARM Cortex-M compiler intrinsics and core functions
cmsis_clang_m.h Clang/LLVM compiler intrinsics with SIMD support for ARM Cortex-M
cmsis_armclang_m.h ARM Clang compiler intrinsics and DSP functions
armv8m_pmu.h ARMv8.1-M Performance Monitoring Unit API definitions
armv8m_mpu.h ARMv8/8.1-M Memory Protection Unit configuration functions
armv81m_pac.h ARMv8.1-M Pointer Authentication Control key management
armv7m_mpu.h ARMv7-M Memory Protection Unit API and region definitions
armv7m_cachel1.h Level 1 cache management functions for ARMv7-M and later
core_sc000.h Secure Core SC000 peripheral access definitions
core_cm1.h Cortex-M1 core peripheral access layer with NVIC support

@Rbb666 Rbb666 merged commit 42458e0 into RT-Thread:master Sep 20, 2025
40 checks passed
@Rbb666 Rbb666 added this to the v5.2.2 milestone Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: new bsp board New added bsp, need sync action BSP: Renesas BSP related with Renesas BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants