Skip to content

Conversation

@hzy0117
Copy link
Contributor

@hzy0117 hzy0117 commented Oct 16, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

编译报错19error,初步判断为RT_USING_IIC没有打开,menuconfig里面要想打开IIC需要同时在 Hardware Drivers Config → On-chip Peripheral Drivs和RT-Thread Components → Device Drirs同时打开IIC

你的解决方案是什么 (what is your solution)

解决办法为在Kconfig的IIC部分加上select Using I2C device drivers

请提供验证的bsp和config (provide the config and bsp)

  • BSP:rt-thread\bsp\renesas\ra8d1-vision-board\board\Kconfig
  • .config:无
  • action:无

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:fix_i2c
  • 设置PR number为 \ Set the PR number to:10822
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 fix_i2c 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix_i2c branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added BSP BSP: Renesas BSP related with Renesas labels Oct 16, 2025
@github-actions
Copy link

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

Reviewers: @kurisaW

Changed Files (Click to expand)
  • bsp/renesas/ra8d1-vision-board/board/Kconfig

📊 Current Review Status (Last Updated: 2025-10-16 13:20 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Rbb666 Rbb666 added this to the v5.2.2 milestone Oct 20, 2025
@Rbb666
Copy link
Member

Rbb666 commented Oct 20, 2025

PR标题修改下,添加上“BSP”/“renesas”关键字,需要说清晰修复了什么问题

@Rbb666 Rbb666 requested a review from Copilot October 20, 2025 06:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a compilation error in the Renesas RA8D1 vision board BSP by adding a missing dependency in the Kconfig configuration. The issue was that enabling hardware I2C in the BSP didn't automatically enable the RT-Thread I2C device driver framework, causing 19 compilation errors.

  • Adds select RT_USING_I2C to the hardware I2C configuration option
  • Resolves the requirement to manually enable I2C drivers in both Hardware Drivers Config and RT-Thread Components menus

menuconfig BSP_USING_HW_I2C
bool "Enable hardware I2C BUS"
default n
select RT_USING_I2C
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[best_practices/最佳实践]: The added dependency select statement correctly resolves the compilation issue. This follows RT-Thread best practices for BSP Kconfig dependencies.

English: The addition of select RT_USING_I2C properly ensures that when hardware I2C is enabled at the BSP level, the corresponding RT-Thread I2C device driver framework is automatically enabled. This prevents the compilation errors and follows the correct dependency pattern.

中文:添加 select RT_USING_I2C 正确地确保了当在 BSP 层启用硬件 I2C 时,相应的 RT-Thread I2C 设备驱动框架会自动启用。这可以防止编译错误并遵循正确的依赖模式。

Copilot generated this review using guidance from repository custom instructions.
@hzy0117 hzy0117 changed the title fix[rsoc]:I2C——Kconfig修改 [BSP][renesas]fix[rsoc]:I2C——Kconfig修改 Oct 20, 2025
@hzy0117 hzy0117 changed the title [BSP][renesas]fix[rsoc]:I2C——Kconfig修改 [BSP][renesas]fix[rsoc]:修复了vision board的I2C开启需要同时打开BSP_USING_I2C和RT_USING_I2C的问题 Oct 20, 2025
@hzy0117 hzy0117 changed the base branch from master to v5.2.2-beta October 20, 2025 07:49
@kurisaW
Copy link
Member

kurisaW commented Oct 20, 2025

PR标题修改下,添加上“BSP”/“renesas”关键字,需要说清晰修复了什么问题

@Rbb666 AI可不可以直接总结PR内容,然后给出标题啊,这种机制能不能实现,也好统一后续版本日志的工作,到时候就能顺着让AI来总结版本日志了

@Rbb666
Copy link
Member

Rbb666 commented Oct 20, 2025

PR标题修改下,添加上“BSP”/“renesas”关键字,需要说清晰修复了什么问题

@Rbb666 AI可不可以直接总结PR内容,然后给出标题啊,这种机制能不能实现,也好统一后续版本日志的工作,到时候就能顺着让AI来总结版本日志了

那得找一个免费的AI,copilot是花钱的

@Rbb666 Rbb666 linked an issue Oct 21, 2025 that may be closed by this pull request
@kurisaW
Copy link
Member

kurisaW commented Oct 21, 2025

在请求触发copliot的时候生成一条标题修改建议评论,这种是不是应该可以实现

@kurisaW kurisaW changed the title [BSP][renesas]fix[rsoc]:修复了vision board的I2C开启需要同时打开BSP_USING_I2C和RT_USING_I2C的问题 [fix][bsp/renesas][rsoc]: add i2c configuration dependency Oct 21, 2025
@Rbb666 Rbb666 merged commit ce63fd7 into RT-Thread:v5.2.2-beta Oct 23, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Renesas BSP related with Renesas BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 5.2.2 版本需合并PR汇总

4 participants