bsp: k230: add i2c driver #10851
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| scons.args: &scons | ||
| scons_arg: | ||
| - '--strict' | ||
| devices.i2c: | ||
| <<: *scons | ||
| kconfig: | ||
| - CONFIG_RT_USING_I2C=y | ||
| - CONFIG_BSP_USING_I2C=y | ||
| - CONFIG_BSP_USING_I2C0=y | ||
| devices.i2c.master: | ||
| <<: *scons | ||
| depends: | ||
| - devices.i2c | ||
| kconfig: | ||
| - CONFIG_BSP_USING_I2C0_MASTER=y | ||
| devices.i2c.slave: | ||
| <<: *scons | ||
| depends: | ||
| - devices.i2c | ||
| kconfig: | ||
| - CONFIG_BSP_USING_I2C0_SLAVE=y |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,110 @@ | ||
| menu "Drivers Configuration" | ||
| menuconfig BSP_USING_I2C | ||
| bool "Enable I2C" | ||
| select RT_USING_I2C | ||
| default n | ||
|
|
||
| if BSP_USING_I2C | ||
| menuconfig BSP_USING_I2C0 | ||
| bool "Enable I2C0" | ||
| default n | ||
|
|
||
| if BSP_USING_I2C0 | ||
| choice BSP_I2C0_DEV_MODE | ||
| prompt "Select I2C0 device mode" | ||
| default BSP_USING_I2C0_MASTER | ||
| help | ||
| Select the I2C0 device mode to be used. | ||
|
Comment on lines
+16
to
+17
There was a problem hiding this comment. English: The help text should be bilingual (English and Chinese) to maintain consistency with RT-Thread's internationalization practices, similar to other BSP configurations in the project. |
||
|
|
||
| config BSP_USING_I2C0_MASTER | ||
| bool "Enable I2C0 Master Mode" | ||
|
Contributor
There was a problem hiding this comment. 建议去掉这里提示里的 I2C0，此时处于 I2C0 的域中不会歧义，二来提示语也可以简短些。 下同，其他也一并修改。 另外有个疑问，既然这里 Mode 是一个简单的二选一类型，要么 master，要么 slave，为何不用简单的 bool 型，用 choice + 两个 config 看上去比较啰嗦，而且定义了两个 BSP_USING_I2C0_MASTER 和 BSP_USING_I2C0_SLAVE 也容易引起歧义，譬如现在搜索 drv_i2c.c 是找不到 BSP_USING_I2C0_MASTER 的，只有 BSP_USING_I2C0_SLAVE，让人有些迷惑。 直接用 bool 会简单很多，譬如： 代码中只要判断 |
||
|
|
||
| config BSP_USING_I2C0_SLAVE | ||
| bool "Enable I2C0 Slave Mode" | ||
|
|
||
| endchoice | ||
| endif | ||
|
|
||
| menuconfig BSP_USING_I2C1 | ||
| bool "Enable I2C1" | ||
| default n | ||
|
|
||
| if BSP_USING_I2C1 | ||
| choice BSP_I2C1_DEV_MODE | ||
| prompt "Select I2C1 device mode" | ||
| default BSP_USING_I2C1_MASTER | ||
| help | ||
| Select the I2C1 device mode to be used. | ||
|
|
||
| config BSP_USING_I2C1_MASTER | ||
| bool "Enable I2C1 Master Mode" | ||
|
|
||
| config BSP_USING_I2C1_SLAVE | ||
| bool "Enable I2C1 Slave Mode" | ||
|
|
||
| endchoice | ||
| endif | ||
|
|
||
| menuconfig BSP_USING_I2C2 | ||
| bool "Enable I2C2" | ||
| default n | ||
|
|
||
| if BSP_USING_I2C2 | ||
| choice BSP_I2C2_DEV_MODE | ||
| prompt "Select I2C2 device mode" | ||
| default BSP_USING_I2C2_MASTER | ||
| help | ||
| Select the I2C2 device mode to be used. | ||
|
|
||
| config BSP_USING_I2C2_MASTER | ||
| bool "Enable I2C2 Master Mode" | ||
|
|
||
| config BSP_USING_I2C2_SLAVE | ||
| bool "Enable I2C2 Slave Mode" | ||
|
|
||
| endchoice | ||
| endif | ||
|
|
||
| menuconfig BSP_USING_I2C3 | ||
| bool "Enable I2C3" | ||
| default n | ||
|
|
||
| if BSP_USING_I2C3 | ||
| choice BSP_I2C3_DEV_MODE | ||
| prompt "Select I2C3 device mode" | ||
| default BSP_USING_I2C3_MASTER | ||
| help | ||
| Select the I2C3 device mode to be used. | ||
|
|
||
| config BSP_USING_I2C3_MASTER | ||
| bool "Enable I2C3 Master Mode" | ||
|
|
||
| config BSP_USING_I2C3_SLAVE | ||
| bool "Enable I2C3 Slave Mode" | ||
|
|
||
| endchoice | ||
| endif | ||
|
|
||
| menuconfig BSP_USING_I2C4 | ||
| bool "Enable I2C4" | ||
| default n | ||
|
|
||
| if BSP_USING_I2C4 | ||
| choice BSP_I2C4_DEV_MODE | ||
| prompt "Select I2C4 device mode" | ||
| default BSP_USING_I2C4_MASTER | ||
| help | ||
| Select the I2C4 device mode to be used. | ||
|
|
||
| config BSP_USING_I2C4_MASTER | ||
| bool "Enable I2C4 Master Mode" | ||
|
|
||
| config BSP_USING_I2C4_SLAVE | ||
| bool "Enable I2C4 Slave Mode" | ||
|
|
||
| endchoice | ||
| endif | ||
| endif | ||
|
|
||
| config BSP_USING_RTC | ||
| bool "Enable RTC" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # RT-Thread building script for I2C component | ||
|
|
||
| from building import * | ||
|
|
||
| cwd = GetCurrentDir() | ||
| src = Glob('*.c') | ||
| CPPPATH = [cwd] | ||
|
|
||
| group = DefineGroup('I2C', src, depend = ['BSP_USING_I2C'], CPPPATH = CPPPATH) | ||
|
|
||
| Return('group') |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CONFIG_RT_USING_I2C 和 CONFIG_RT_USING_I2C_BITOPS 为何会新增？是不是本地测试后 commit 时忘记清除了？
请最终提交时确保回退所有
.config和rtconfig.h的改动，然后只执行过一次scons --menuconfig。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个我提交之前把.config重置了，然后打开menuconfig，然后保存一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你想说明什么问题我没有看懂，但实际问题就是这些 I2C 的配置默认就是关的，你这里开了是不对的。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
提交之前回退过，可能是又测试过，我改了之后处理一下