Skip to content

Conversation

@Dailingxiang1
Copy link
Contributor

@Dailingxiang1 Dailingxiang1 commented Nov 9, 2025

拉取/合并请求描述:(PR description)

[

提交此PR的原因:

  • 新增stm32f407-micu板卡的BSP支持,丰富RT-Thread的硬件生态
  • 该板卡是一款基于STM32F407VET6的教学开发板,具有丰富的外设资源

解决的问题:

  • 提供了stm32f407-micu板卡的基础BSP支持
  • 配置了系统时钟、串口控制台等基础驱动
  • 实现了GPIO、UART等基本外设的驱动支持
  • 并确认并列出已经在什么情况或板卡上进行了测试。

已测试的环境:

  • MDK543 ArmClang v6.24

  • arm-none-eabi-gcc Scons构建

  • IAR 8.32.1

  • 代码已经过astyle工具规范

  • BSP: bsp/stm32/stm32f407-micu

  • .config: 本 PR 未对默认配置做修改,使用 BSP 目录下现有的默认 .config 即可完成编译和验证。

  • action: https://github.com/ZKZzhu/rt-thread/edit/bsp/stm32f407-micu/.github/workflows/bsp_buildings.yml

  • (由于本人账号出现billing issue错误无法直接编译,故请好友fork我的仓库进行测试,望见谅)
    ]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:bsp/stm32f407-micu
  • 设置PR number为 \ Set the PR number to:10912
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 bsp/stm32f407-micu 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the bsp/stm32f407-micu branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: Liang1795 hamburger-os wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-micu/.config
  • bsp/stm32/stm32f407-micu/.gitignore
  • bsp/stm32/stm32f407-micu/Kconfig
  • bsp/stm32/stm32f407-micu/README.md
  • bsp/stm32/stm32f407-micu/SConscript
  • bsp/stm32/stm32f407-micu/SConstruct
  • bsp/stm32/stm32f407-micu/applications/SConscript
  • bsp/stm32/stm32f407-micu/applications/main.c
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/.mxproject
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/CubeMX_Config.ioc
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/main.h
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/stm32f4xx_hal_conf.h
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/stm32f4xx_it.h
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/main.c
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/stm32f4xx_hal_msp.c
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/stm32f4xx_it.c
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/system_stm32f4xx.c
  • bsp/stm32/stm32f407-micu/board/Kconfig
  • bsp/stm32/stm32f407-micu/board/SConscript
  • bsp/stm32/stm32f407-micu/board/board.c
  • bsp/stm32/stm32f407-micu/board/board.h
  • bsp/stm32/stm32f407-micu/board/linker_scripts/link.icf
  • bsp/stm32/stm32f407-micu/board/linker_scripts/link.lds
  • bsp/stm32/stm32f407-micu/board/linker_scripts/link.sct
  • bsp/stm32/stm32f407-micu/figures/board.png
  • bsp/stm32/stm32f407-micu/project.ewd
  • bsp/stm32/stm32f407-micu/project.ewp
  • bsp/stm32/stm32f407-micu/project.eww

🏷️ Tag: maintainers

Reviewers: Rbb666 kurisaW

Changed Files (Click to expand)
  • MAINTAINERS

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)
  • .github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-11-11 11:55 CST)

  • Liang1795 Pending Review
  • Rbb666 Pending Review
  • hamburger-os Pending Review
  • kurisaW Pending Review
  • supperthomas Pending Review
  • wdfk-prog Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP action github action yml imporve labels Nov 9, 2025
@Dailingxiang1 Dailingxiang1 force-pushed the bsp/stm32f407-micu branch 2 times, most recently from 3615e8b to 13758f3 Compare November 9, 2025 12:06
@Rbb666 Rbb666 requested a review from Copilot November 9, 2025 13:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds BSP (Board Support Package) support for the STM32F407-MICU development board to RT-Thread. The STM32F407-MICU is an educational development board based on the STM32F407VET6 microcontroller. The implementation includes basic system configuration, peripheral drivers (GPIO, UART), and support for three major toolchains (MDK, GCC, IAR).

Key changes:

  • Complete BSP infrastructure including build configurations for MDK/GCC/IAR toolchains
  • System clock configuration using HSI with PLL to achieve 168 MHz operation
  • Basic peripheral driver support (GPIO, UART1 console)

Reviewed Changes

Copilot reviewed 34 out of 42 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
rtconfig.py Build configuration supporting GCC, Keil MDK, and IAR toolchains
rtconfig.h RT-Thread kernel and component configuration header
project.uvprojx/uvproj/uvoptx Keil MDK project files for ARM Compiler 6 and v5
project.eww IAR workspace configuration
board/linker_scripts/* Linker scripts for all three toolchains (GCC/MDK/IAR)
board/board.h/c Board initialization and system clock configuration
board/Kconfig BSP configuration options for peripheral drivers
board/SConscript SCons build script for board-specific files
applications/main.c Sample application demonstrating LED blinking

@Rbb666
Copy link
Member

Rbb666 commented Nov 9, 2025

还请添加此BSP到ci看护:https://github.com/RT-Thread/rt-thread/blob/master/.github/ALL_BSP_COMPILE.json

@Dailingxiang1
Copy link
Contributor Author

已添加,谢谢提醒> 还请添加此BSP到ci看护:https://github.com/RT-Thread/rt-thread/blob/master/.github/ALL_BSP_COMPILE.json

@kurisaW
Copy link
Member

kurisaW commented Nov 10, 2025

请作者压缩一下提交,保留一个commit即可

@Dailingxiang1
Copy link
Contributor Author

请作者压缩一下提交,保留一个commit即可

收到,已合并

@Rbb666
Copy link
Member

Rbb666 commented Nov 11, 2025

另外,作者如果后续会持续维护此BSP的话,可以将您的账号添加到对应的maintainer字段,方便后续维护:https://github.com/RT-Thread/rt-thread/blob/master/MAINTAINERS

Update bsp/stm32/stm32f407-micu/rtconfig.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update bsp/stm32/stm32f407-micu/rtconfig.h

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update bsp/stm32/stm32f407-micu/project.uvproj

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update bsp/stm32/stm32f407-micu/project.uvproj

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update bsp/stm32/stm32f407-micu/board/board.h

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

add ci

Delete bsp/stm32/stm32f407-micu/project.uvgui.dlx

	modified:   MAINTAINERS
	deleted:    bsp/stm32/stm32f407-micu/figures/board.png.png
	deleted:    bsp/stm32/stm32f407-micu/project.uvopt
	modified:   bsp/stm32/stm32f407-micu/project.uvoptx
	modified:   bsp/stm32/stm32f407-micu/project.uvprojx
@Rbb666 Rbb666 merged commit 11a2f7e into RT-Thread:master Nov 11, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action github action yml imporve BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants